Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/refactor anomaly test output #112

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

lorenzomammana
Copy link
Contributor

Summary

In 2.1.0 we introduced the usage of the normalized anomaly score for anomaly detection, this score is now the preferred way to work.

In order to remove the necessity of a double threshold (one for the model and one for normalized score) the goal is to unify these concepts so that the model training threshold is fixed, while the normalized threshold can vary and is used as decision boundary.

While it's a breaking change it can be seen as part of the 2.1.0 refactoring :)

Type of Change

Please select the one relevant option below:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

@lorenzomammana lorenzomammana requested a review from rcmalli April 17, 2024 12:20
@lorenzomammana lorenzomammana self-assigned this Apr 17, 2024
@lorenzomammana lorenzomammana merged commit a79d63a into main Apr 18, 2024
2 checks passed
@lorenzomammana lorenzomammana deleted the feat/refactor-anomaly-test-output branch April 18, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants