-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMake option BUILD_OROGEN and update metapackage manifest to format 3 #37
Conversation
orogen dependency utilrb depends on metaruby (https://github.com/rock-core/tools-metaruby), a package that is not available from default package repostories of common Linux distributions. It needs to be installed as a Ruby gem or from source. Until a unified way of bootstrapping the toolchain with or without Ruby and optional packages I therefore suggest to disable orogen for CMake-based builds by default.
…ate maintainer email
This is of course your choice, but I'm a bit puzzled on the metaruby argument. Metaruby is essentially maintained by the same people than utilrb, orogen and typelib ... so what gives ? Why does it need to be available from packages while the others aren't. From where I stand, it seems to be "we don't need orogen, so we don't want to have to maintain its build and installation". Which is totally fair of course. Just trying to understand the underlying reason. |
You are right. In the first place I needed a quick way to get started with building RTT and OCL in a pure ROS 2 environment without catkin or Autoproj. The new top-level The difference with From an earlier comment I remember that you actually would like to remove I am not against keeping orogen as part of the Orocos Toolchain and raised that question again in |
I'd like to, the same way that you'd like to remove |
ab09e06
to
17e610c
Compare
I will go ahead and apply the patch to This is mainly to align the repository state with the documentation at https://docs.orocos.org/docs_main/installation.html#using-cmake-default-way, which at the moment would require the installation of additional dependencies without this patch. It would be possible to add a command line flag to the configure script for |
#34 added a new top-level
CMakeLists.txt
to build the toolchain packages with CMake and ExternalProject.Not all Orocos users require orogen, which brings in Ruby and other dependencies. Furthermore dependency
utilrb
depends onmetaruby
(https://github.com/rock-core/tools-metaruby), a package that is not available from default package repositories of common Linux distributions and cannot be built with CMake today. It needs to be installed as a Ruby gem or from source or with AutoProj. Splitting off the "core" packages RTT and OCL from orogen and other Ruby dependencies was already suggested in #18, without a conclusion yet.Until a unified way of bootstrapping the toolchain with or without Ruby and optional packages has been implemented, or until it has been decided to remove orogen submodules or even this whole meta-repository, I suggest to disable orogen by default for pure CMake builds that use the top-level
CMakeLists.txt
. For starting on ROS 2 support we would like to have a way to build RTT and OCL without catkin, but also without adding explicit support for new build tools like colcon and ament_cmake and without introducing a "new" build tool like AutoProj for ROS users, which would make it impossible to release into the ROS ecosystem.The
package.xml
file of theorocos_toolchain
metapackage has been update to format 3, following orocos-toolchain/rtt#321 and orocos-toolchain/ocl#90, with the optional dependencies (and their licenses) removed. The metapackage is relevant for catkin builds only.