Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to override the FrontendCustomerUserFormProvider #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

flochntrl
Copy link

@flochntrl flochntrl commented Apr 5, 2019

  • FrontendCustomerUserFormProvider : Make it easier to override
  • ResetController : use symfony standards

@orocla orocla added the cla: yes label Apr 5, 2019
@anyt
Copy link
Contributor

anyt commented Apr 5, 2019

Thank you for contribution @flochntrl

ResetController : use Symfony standards

These changes look unrelated to the described issue. As we use the same style in a lot of other controllers, I think it makes sense to leave it as is or fix all of them at once.

@flochntrl
Copy link
Author

flochntrl commented Apr 5, 2019

I'm agree with your comment. I edit it because i work actually on it.

I rollback the controller because it isn't the PR to do that.

And i'll clean the git history

@anyt
Copy link
Contributor

anyt commented Apr 5, 2019

Changing self to static looks reasonable, everything else I guess should be reversed.

Please do not submit changes that are not tested, at least manually, but better with automated tests.
FrontendCustomerUserFormProvider class is covered with a unit test. You can update it to make sure the changes work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants