-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easier to override the FrontendCustomerUserFormProvider #8
base: master
Are you sure you want to change the base?
Conversation
flochntrl
commented
Apr 5, 2019
•
edited
Loading
edited
- FrontendCustomerUserFormProvider : Make it easier to override
- ResetController : use symfony standards
Thank you for contribution @flochntrl
These changes look unrelated to the described issue. As we use the same style in a lot of other controllers, I think it makes sense to leave it as is or fix all of them at once. |
I'm agree with your comment. I edit it because i work actually on it. I rollback the controller because it isn't the PR to do that. And i'll clean the git history |
c0939ee
to
528b8ad
Compare
src/Oro/Bundle/CustomerBundle/Layout/DataProvider/FrontendCustomerUserFormProvider.php
Outdated
Show resolved
Hide resolved
src/Oro/Bundle/CustomerBundle/Layout/DataProvider/FrontendCustomerUserFormProvider.php
Outdated
Show resolved
Hide resolved
Changing self to static looks reasonable, everything else I guess should be reversed. Please do not submit changes that are not tested, at least manually, but better with automated tests. |