Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sass configuration refactor #154
base: main
Are you sure you want to change the base?
Sass configuration refactor #154
Changes from all commits
859e570
459f337
2187e97
112b525
a67def3
0234418
55f8222
57a0899
914a9ce
5dcaa51
8adb984
11e3b6f
aafe2fa
a44fcc4
5961301
fb175e3
2b14863
d19b152
e9577a6
c6df699
7fccf65
3a98fa9
96192f3
94f6879
95190f0
2995137
2458a07
96c8ac4
aee3e46
f564dc5
f0230ca
83d7835
4ee57dc
c8b341b
fde3ea1
022363d
bccdaaf
4925060
f8aa5ff
fe1be7d
21077c0
fef3d5f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Could you explain to me again why we have to have the component variables in their own files in the "component-defaults" folder and can't have them in the "components" folder files?
I'm a bit confused because the
@forward "component-defaults";
comes just before the@forward "bulma";
not only in this file, but also in the "component-only-build.scss" file...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the hoisting problem. if you put the defaults in the main component files then if the default is used the whole file gets hoisted. this isn't a problem for the defaults generally, but it will hoist other use or forward statements in the file, which typically shifts a Bulma @use before the primary Bulma @use with (...). There are a few files which don't use Bulma like that where in theory we could get away with putting them together, but that's the exception rather than the rule, and i think the mixing of patterns will just confuse future coders. trust me, this pattern feel inelegant to me too, but it seems to be unavoidable.