fix: Correctly set type for false or 0 constants (#1653)

* chore: Expand const specification with false and 0 constants * fix: Correctly set type for false or 0 constants
orval-labs · Oct 1, 2024 · 4692501 · 4692501
1 parent b3b0306
commit 4692501
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/packages/core/src/getters/scalar.ts b/packages/core/src/getters/scalar.ts
@@ -52,7 +52,7 @@ export const getScalar = ({
       }
 
       const itemWithConst = item as SchemaWithConst;
-      if (itemWithConst.const) {
+      if (itemWithConst.const !== undefined) {
         value = itemWithConst.const;
       }
 
@@ -73,7 +73,7 @@ export const getScalar = ({
       let value = 'boolean';
 
       const itemWithConst = item as SchemaWithConst;
-      if (itemWithConst.const) {
+      if (itemWithConst.const !== undefined) {
         value = itemWithConst.const;
       }
 

diff --git a/tests/specifications/const.yaml b/tests/specifications/const.yaml
@@ -26,11 +26,15 @@ components:
       type: object
       required:
         - value
+        - valueFalse
         - valueNullable
       properties:
         value:
           type: boolean
           const: true
+        valueFalse:
+          type: boolean
+          const: false
         valueNullable:
           type:
             - boolean
@@ -40,11 +44,15 @@ components:
       type: object
       required:
         - value
+        - valueZero
         - valueNullable
       properties:
         value:
           type: number
           const: 1
+        valueZero:
+          type: number
+          const: 0
         valueNullable:
           type:
             - number