fix(msw): Incorrect Import Generated for Enum in Mock Files #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already done in the core package but was not done during the generation of the MSW defintions.
Added a new enumeration `Domain.Status.Enum` to represent the status of pets with values. This enum I used to test if the MSW definitions where generated correct.
|
cc @dteske25 |
melloware
approved these changes
Sep 23, 2024
dteske25
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
fix #1620
WIP
Description
Fixes the issue mention in #1620. It now imports like this
import { DomainStatusEnum } from '.././model';instead ofimport { Domain.Status.Enum } from '.././model';Todos
It is realy difficult to check if I didn't broken anything after the change. When i ran generate api on vue-query sample it looked good and only added the new correct import statments. Thats why i marked it as WIP. If you have tips to test it better please let me know.