Skip to content

feat: add support for Proof Key For Code Exchange (PKCE) in OIDC social providers #4574

feat: add support for Proof Key For Code Exchange (PKCE) in OIDC social providers

feat: add support for Proof Key For Code Exchange (PKCE) in OIDC social providers #4574

Triggered via pull request August 13, 2024 09:05
Status Failure
Total duration 50m 46s
Artifacts

ci.yaml

on: pull_request
Run tests and lints
2m 3s
Run tests and lints
Matrix: Run end-to-end tests
Matrix: Run Playwright end-to-end tests
Build CLI docs
0s
Build CLI docs
Generate changelog
0s
Generate changelog
Generate release
0s
Generate release
Draft newsletter
0s
Draft newsletter
Render version schema
0s
Render version schema
Release SDKs
0s
Release SDKs
Pending approval Slack notification
0s
Pending approval Slack notification
Send newsletter
0s
Send newsletter
Fit to window
Zoom out
Zoom in

Annotations

10 errors, 29 warnings, and 4 notices
Run tests and lints: selfservice/strategy/oidc/strategy_login.go#L267
Error return value is not checked (errcheck)
Run tests and lints
issues found
[chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh: test/e2e/playwright/tests/desktop/identifier_first/password.login.spec.ts#L1
1) [chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh Test timeout of 30000ms exceeded.
[chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh: test/e2e/playwright/models/elements/login.ts#L147
1) [chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh Error: page.waitForURL: Test timeout of 30000ms exceeded. =========================== logs =========================== waiting for navigation until "load" ============================================================ at ../models/elements/login.ts:147 145 | async submit(method: string, opts?: SubmitOptions) { 146 | const nav = opts?.waitForURL > 147 | ? this.page.waitForURL(opts.waitForURL) | ^ 148 | : Promise.resolve() 149 | if (opts?.submitWithKeyboard) { 150 | await this.page.keyboard.press("Enter") at LoginPage.submit (/home/runner/work/kratos/kratos/test/e2e/playwright/models/elements/login.ts:147:19) at /home/runner/work/kratos/kratos/test/e2e/playwright/tests/desktop/identifier_first/password.login.spec.ts:104:17
[chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh: test/e2e/playwright/tests/desktop/identifier_first/password.login.spec.ts#L1
1) [chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh Test timeout of 30000ms exceeded.
[chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh: test/e2e/playwright/models/elements/login.ts#L147
1) [chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh Error: page.waitForURL: Test timeout of 30000ms exceeded. =========================== logs =========================== waiting for navigation until "load" ============================================================ at ../models/elements/login.ts:147 145 | async submit(method: string, opts?: SubmitOptions) { 146 | const nav = opts?.waitForURL > 147 | ? this.page.waitForURL(opts.waitForURL) | ^ 148 | : Promise.resolve() 149 | if (opts?.submitWithKeyboard) { 150 | await this.page.keyboard.press("Enter") at LoginPage.submit (/home/runner/work/kratos/kratos/test/e2e/playwright/models/elements/login.ts:147:19) at /home/runner/work/kratos/kratos/test/e2e/playwright/tests/desktop/identifier_first/password.login.spec.ts:104:17
[chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh: test/e2e/playwright/tests/desktop/identifier_first/password.login.spec.ts#L1
1) [chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh Test timeout of 30000ms exceeded.
[chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh: test/e2e/playwright/models/elements/login.ts#L147
1) [chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh Error: page.waitForURL: Test timeout of 30000ms exceeded. =========================== logs =========================== waiting for navigation until "load" ============================================================ at ../models/elements/login.ts:147 145 | async submit(method: string, opts?: SubmitOptions) { 146 | const nav = opts?.waitForURL > 147 | ? this.page.waitForURL(opts.waitForURL) | ^ 148 | : Promise.resolve() 149 | if (opts?.submitWithKeyboard) { 150 | await this.page.keyboard.press("Enter") at LoginPage.submit (/home/runner/work/kratos/kratos/test/e2e/playwright/models/elements/login.ts:147:19) at /home/runner/work/kratos/kratos/test/e2e/playwright/tests/desktop/identifier_first/password.login.spec.ts:104:17
[chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh: test/e2e/playwright/tests/desktop/identifier_first/password.login.spec.ts#L1
1) [chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh Test timeout of 30000ms exceeded.
[chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh: test/e2e/playwright/models/elements/login.ts#L147
1) [chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh Error: page.waitForURL: Test timeout of 30000ms exceeded. =========================== logs =========================== waiting for navigation until "load" ============================================================ at ../models/elements/login.ts:147 145 | async submit(method: string, opts?: SubmitOptions) { 146 | const nav = opts?.waitForURL > 147 | ? this.page.waitForURL(opts.waitForURL) | ^ 148 | : Promise.resolve() 149 | if (opts?.submitWithKeyboard) { 150 | await this.page.keyboard.press("Enter") at LoginPage.submit (/home/runner/work/kratos/kratos/test/e2e/playwright/models/elements/login.ts:147:19) at /home/runner/work/kratos/kratos/test/e2e/playwright/tests/desktop/identifier_first/password.login.spec.ts:104:17
Generate SDKs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Generate SDKs
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-go@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Generate SDKs
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-go@v2, actions/cache@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run tests and lints
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Run tests and lints
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-go@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Playwright end-to-end tests (mysql)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Run Playwright end-to-end tests (mysql)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v2, actions/setup-go@v4, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Slow Test: test/e2e/[mobile-chrome] › mobile/app_login.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_login.spec.ts took 29.7s
Slow Test: test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts took 25.0s
Run Playwright end-to-end tests (sqlite)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Run Playwright end-to-end tests (sqlite)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v2, actions/setup-go@v4, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Slow Test: test/e2e/[mobile-chrome] › mobile/app_login.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_login.spec.ts took 30.4s
Slow Test: test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts took 24.7s
Run Playwright end-to-end tests (postgres)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Run Playwright end-to-end tests (postgres)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v2, actions/setup-go@v4, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Slow Test: test/e2e/[mobile-chrome] › mobile/app_login.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_login.spec.ts took 30.9s
Slow Test: test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts took 25.4s
Run Playwright end-to-end tests (cockroach)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Run Playwright end-to-end tests (cockroach)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v2, actions/setup-go@v4, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Slow Test: test/e2e/[mobile-chrome] › mobile/app_login.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_login.spec.ts took 29.1s
Slow Test: test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts took 21.8s
Run end-to-end tests (postgres)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Run end-to-end tests (postgres)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v2, actions/setup-go@v4, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run end-to-end tests (mysql)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Run end-to-end tests (mysql)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v2, actions/setup-go@v4, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run end-to-end tests (sqlite)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Run end-to-end tests (sqlite)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v2, actions/setup-go@v4, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run end-to-end tests (cockroach)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Run end-to-end tests (cockroach)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v2, actions/setup-go@v4, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
🎭 Playwright Run Summary
1 flaky [chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh 34 passed (2.4m)
🎭 Playwright Run Summary
1 flaky [chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh 34 passed (2.4m)
🎭 Playwright Run Summary
1 flaky [chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh 34 passed (2.4m)
🎭 Playwright Run Summary
1 flaky [chromium] › desktop/identifier_first/password.login.spec.ts:75:7 › account enumeration protection off › login with refresh 34 passed (2.8m)