Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oidc provider epic games #3449

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jorgagu
Copy link

@Jorgagu Jorgagu commented Aug 22, 2023

Implementation of Epic Games OpenID Connect.

https://dev.epicgames.com/docs/web-api-ref/authentication

https://api.epicgames.dev/epic/oauth/v1/.well-known/openid-configuration

It's almost work with provider generic but the token endpoint need the client id and client secret in Authorization basic header.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (67360cf) 78.33% compared to head (5233571) 78.17%.
Report is 5 commits behind head on master.

❗ Current head 5233571 differs from pull request most recent head 483da7e. Consider uploading reports for the commit 483da7e to get more accurate results

Files Patch % Lines
selfservice/strategy/oidc/provider_epic_games.go 0.00% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3449      +/-   ##
==========================================
- Coverage   78.33%   78.17%   -0.16%     
==========================================
  Files         347      347              
  Lines       23804    23671     -133     
==========================================
- Hits        18646    18505     -141     
- Misses       3749     3765      +16     
+ Partials     1409     1401       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jorgagu Jorgagu force-pushed the feat/oidc-provider-epic-games branch 6 times, most recently from e91e50b to 3ef7c96 Compare August 25, 2023 08:57
@Jorgagu Jorgagu force-pushed the feat/oidc-provider-epic-games branch 2 times, most recently from d7552d5 to fdf9df2 Compare October 9, 2023 21:14
@Jorgagu Jorgagu force-pushed the feat/oidc-provider-epic-games branch 4 times, most recently from e777f32 to 6d53051 Compare November 13, 2023 13:44
@Jorgagu Jorgagu force-pushed the feat/oidc-provider-epic-games branch 3 times, most recently from 137daed to 6c7757d Compare January 8, 2024 14:38
@Jorgagu Jorgagu force-pushed the feat/oidc-provider-epic-games branch 4 times, most recently from b7df570 to 2ed6abc Compare January 18, 2024 10:56
@Jorgagu Jorgagu force-pushed the feat/oidc-provider-epic-games branch 2 times, most recently from b45cfc7 to 5233571 Compare January 25, 2024 13:06
@Jorgagu Jorgagu force-pushed the feat/oidc-provider-epic-games branch from 5233571 to 483da7e Compare February 2, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant