Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve tracing on recovery and verification #3586

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Oct 19, 2023
aeneasr
aeneasr previously approved these changes Oct 24, 2023
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #3586 (5dc724d) into master (f7c6767) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 5dc724d differs from pull request most recent head 495203e. Consider uploading reports for the commit 495203e to get more accurate results

@@            Coverage Diff             @@
##           master    #3586      +/-   ##
==========================================
+ Coverage   78.26%   78.31%   +0.04%     
==========================================
  Files         342      342              
  Lines       23402    23414      +12     
==========================================
+ Hits        18316    18336      +20     
+ Misses       3705     3699       -6     
+ Partials     1381     1379       -2     
Files Coverage Δ
selfservice/strategy/code/strategy_login.go 72.14% <100.00%> (ø)
selfservice/strategy/code/strategy_recovery.go 71.52% <100.00%> (+0.18%) ⬆️
selfservice/strategy/code/strategy_verification.go 72.06% <100.00%> (+0.47%) ⬆️
selfservice/strategy/link/strategy.go 100.00% <ø> (ø)
selfservice/strategy/link/strategy_recovery.go 64.75% <100.00%> (+0.43%) ⬆️
selfservice/strategy/link/strategy_verification.go 63.46% <100.00%> (+0.96%) ⬆️

... and 2 files with indirect coverage changes

@jonas-jonas jonas-jonas requested a review from aeneasr November 12, 2023 13:38
@alnr alnr merged commit b2b231e into master Nov 13, 2023
26 checks passed
@alnr alnr deleted the jonas-jonas/codeTracingImprovements branch November 13, 2023 10:10
moose115 pushed a commit to moose115/kratos that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants