Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix github.com/bxcodec/faker/v3 is deprecated #3607

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

anhnmt
Copy link
Contributor

@anhnmt anhnmt commented Nov 1, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CLAassistant
Copy link

CLAassistant commented Nov 1, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #3607 (afb9600) into master (7c54c9f) will decrease coverage by 0.10%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head afb9600 differs from pull request most recent head fdda2ef. Consider uploading reports for the commit fdda2ef to get more accurate results

@@            Coverage Diff             @@
##           master    #3607      +/-   ##
==========================================
- Coverage   78.30%   78.20%   -0.10%     
==========================================
  Files         342      341       -1     
  Lines       23378    23142     -236     
==========================================
- Hits        18306    18099     -207     
+ Misses       3697     3687      -10     
+ Partials     1375     1356      -19     
Files Coverage Δ
corpx/faker.go 42.52% <ø> (ø)
courier/test/persistence.go 100.00% <ø> (ø)
identity/test/pool.go 99.58% <ø> (ø)
persistence/sql/persister_registration_code.go 83.33% <ø> (ø)
selfservice/flow/login/test/persistence.go 100.00% <ø> (ø)
selfservice/flow/recovery/test/persistence.go 100.00% <ø> (ø)
selfservice/flow/registration/test/persistence.go 100.00% <ø> (ø)
selfservice/flow/settings/test/persistence.go 100.00% <ø> (ø)
selfservice/flow/verification/test/persistence.go 100.00% <ø> (ø)
selfservice/strategy/code/test/persistence.go 100.00% <ø> (ø)
... and 2 more

... and 24 files with indirect coverage changes

@anhnmt anhnmt marked this pull request as ready for review November 1, 2023 09:25
@aeneasr aeneasr merged commit 843a215 into ory:master Nov 10, 2023
25 checks passed
@anhnmt anhnmt deleted the go-faker branch November 15, 2023 14:41
moose115 pushed a commit to moose115/kratos that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants