Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't return nil if code is invalid #3662

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Dec 13, 2023

Related issue(s)

Closes https://github.com/ory-corp/cloud/issues/5648

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6cf7fc5) 78.38% compared to head (f5b6054) 78.34%.
Report is 1 commits behind head on master.

Files Patch % Lines
selfservice/strategy/code/strategy_verification.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3662      +/-   ##
==========================================
- Coverage   78.38%   78.34%   -0.04%     
==========================================
  Files         345      345              
  Lines       23552    23518      -34     
==========================================
- Hits        18461    18426      -35     
- Misses       3695     3699       +4     
+ Partials     1396     1393       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas merged commit df8ec2b into master Dec 14, 2023
29 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/fixNoMoreReturnNil branch December 14, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants