Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3675. It makes sure that the sdk generated names
ids_filter
are in sync with the actual query parameter.If instead the name
ids
should continue to be used, the spec should be updated so that the sdk clients will generate correctly, but I am not sure how to type hint this.I think the spec is defined here:
kratos/identity/pool.go
Lines 17 to 28 in 699e5d5
I am not entirely sure in how many places this is feature is tested, I was searching through the repo and didn't really find any success, so if you could let me know where I find the tests, I can update them.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments