Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add caching to Jsonnet snippet during session JWT tokenization #3699

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Jan 18, 2024

No description provided.

@alnr alnr self-assigned this Jan 18, 2024
zepatrik
zepatrik previously approved these changes Jan 18, 2024
jonas-jonas
jonas-jonas previously approved these changes Jan 18, 2024
@alnr alnr enabled auto-merge (squash) January 18, 2024 11:22
@alnr
Copy link
Contributor Author

alnr commented Jan 18, 2024

test failures seem unrelated

@alnr alnr dismissed stale reviews from jonas-jonas and zepatrik via 13bcf17 January 18, 2024 11:35
@alnr alnr force-pushed the cache-tokenizer-snippet branch from 13bcf17 to fb5b12e Compare January 18, 2024 11:42
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (21ab031) 79.47% compared to head (fb5b12e) 78.29%.

Files Patch % Lines
session/tokenizer.go 42.85% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3699      +/-   ##
==========================================
- Coverage   79.47%   78.29%   -1.18%     
==========================================
  Files         356      346      -10     
  Lines       25999    23561    -2438     
==========================================
- Hits        20662    18448    -2214     
+ Misses       3826     3717     -109     
+ Partials     1511     1396     -115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zepatrik zepatrik disabled auto-merge January 18, 2024 12:37
@zepatrik zepatrik removed request for hperl and aeneasr January 18, 2024 12:38
@zepatrik zepatrik merged commit 1da8180 into master Jan 18, 2024
28 of 29 checks passed
@zepatrik zepatrik deleted the cache-tokenizer-snippet branch January 18, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants