Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jsonnet caching for OIDC claims mapper, webhooks, JWT session tokenizer #3701

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Jan 18, 2024

Requires ory/x#753

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d93570d) 78.94% compared to head (087dc69) 78.33%.
Report is 1 commits behind head on master.

Files Patch % Lines
session/tokenizer.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3701      +/-   ##
==========================================
- Coverage   78.94%   78.33%   -0.62%     
==========================================
  Files         347      346       -1     
  Lines       24553    23555     -998     
==========================================
- Hits        19384    18452     -932     
+ Misses       3746     3710      -36     
+ Partials     1423     1393      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alnr alnr self-assigned this Jan 18, 2024
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please just adjust the cache configs. Maybe it also makes sense to use a global cache instead of several individual caches at some point, to improve memory management.

selfservice/hook/web_hook.go Show resolved Hide resolved
session/tokenizer.go Show resolved Hide resolved
@alnr alnr enabled auto-merge (squash) January 19, 2024 10:44
@aeneasr aeneasr disabled auto-merge January 19, 2024 11:28
@aeneasr aeneasr merged commit 1d26e09 into master Jan 19, 2024
29 checks passed
@aeneasr aeneasr deleted the caching-fetcher branch January 19, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants