Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve login tests #3969

Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jun 24, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from jonas-jonas June 24, 2024 14:42
@aeneasr aeneasr requested review from zepatrik and hperl as code owners June 24, 2024 14:42
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.33%. Comparing base (84fff3c) to head (52b6fcd).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           jonas-jonas/e2eTestsTwoStepLogin    #3969   +/-   ##
=================================================================
  Coverage                             78.33%   78.33%           
=================================================================
  Files                                   367      367           
  Lines                                 25876    25876           
=================================================================
  Hits                                  20270    20270           
  Misses                                 4066     4066           
  Partials                               1540     1540           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas merged commit 52b6fcd into jonas-jonas/e2eTestsTwoStepLogin Jun 25, 2024
19 of 24 checks passed
@jonas-jonas jonas-jonas deleted the aeneasr/two-step-login/e2e-tests branch June 25, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants