Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typo in changelog #3976

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

David-Wobrock
Copy link
Contributor

@David-Wobrock David-Wobrock commented Jul 1, 2024

The code uses selfservice.flows.registration.enable_legacy_one_step everywhere, so I believe enable_legacy_flow won't work.

To be changed in https://github.com/ory/kratos/releases/tag/v1.2.0 also :)

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@zepatrik zepatrik changed the title fix: misnamed configuration option 'enable_legacy_one_step' in changelog docs: typo in changelog Jul 1, 2024
@zepatrik zepatrik merged commit c508980 into ory:master Jul 1, 2024
21 of 23 checks passed
@David-Wobrock David-Wobrock deleted the fix/typo-changelog branch July 1, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants