Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return credentials in FindByCredentialsIdentifier #4068

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Aug 30, 2024

Instead of re-fetching the credentials later (expensive), we load them only once.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Instead of re-fetching the credentials later (expensive), we load them only once.
@aeneasr aeneasr requested review from zepatrik and hperl as code owners August 30, 2024 09:26
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.39%. Comparing base (dbf7274) to head (95c3694).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
session/manager_http.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4068      +/-   ##
==========================================
- Coverage   78.44%   78.39%   -0.06%     
==========================================
  Files         373      373              
  Lines       26739    26498     -241     
==========================================
- Hits        20975    20772     -203     
+ Misses       4175     4138      -37     
+ Partials     1589     1588       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit f949173 into master Aug 30, 2024
22 checks passed
@aeneasr aeneasr deleted the improve-latency branch August 30, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant