Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: client-side PKCE take 3 #4078

Merged
merged 4 commits into from
Sep 12, 2024

feat: client-side PKCE

91b5cd3
Select commit
Loading
Failed to load commit list.
Merged

feat: client-side PKCE take 3 #4078

feat: client-side PKCE
91b5cd3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 11, 2024 in 0s

78.46% (target 70.00%)

View this Pull Request on Codecov

78.46% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 64.23841% with 108 lines in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (5592029) to head (91b5cd3).

Files with missing lines Patch % Lines
gen/oidc/v1/state.pb.go 57.53% 29 Missing and 2 partials ⚠️
selfservice/strategy/oidc/strategy.go 56.86% 20 Missing and 2 partials ⚠️
selfservice/strategy/oidc/strategy_registration.go 45.00% 19 Missing and 3 partials ⚠️
selfservice/strategy/oidc/strategy_login.go 44.00% 13 Missing and 1 partial ⚠️
selfservice/strategy/oidc/state.go 78.33% 6 Missing and 7 partials ⚠️
cipher/chacha20.go 0.00% 1 Missing and 1 partial ⚠️
selfservice/strategy/oidc/pkce.go 94.28% 1 Missing and 1 partial ⚠️
selfservice/strategy/oidc/strategy_settings.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4078      +/-   ##
==========================================
- Coverage   78.92%   78.46%   -0.46%     
==========================================
  Files         373      376       +3     
  Lines       27123    26728     -395     
==========================================
- Hits        21406    20973     -433     
- Misses       4129     4150      +21     
- Partials     1588     1605      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov