Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump the GitHub Actions upload-artifact version #4087

Conversation

David-Wobrock
Copy link
Contributor

@David-Wobrock David-Wobrock commented Sep 10, 2024

Relates to https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
and failing builds because of this: https://github.com/ory/kratos/actions/runs/10789014984/job/29921225239?pr=4086#step:1:36

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@David-Wobrock David-Wobrock marked this pull request as ready for review September 10, 2024 10:14
@David-Wobrock
Copy link
Contributor Author

David-Wobrock commented Sep 10, 2024

Superseded by #4088 maybe :)

@hperl
Copy link
Contributor

hperl commented Sep 11, 2024

Superseded by #4088 maybe :)

Yes, maybe. I found that the upload action now wants distinct names for the individual items, which I addressed in that PR.

@alnr
Copy link
Contributor

alnr commented Sep 11, 2024

Fixed in #4085, thanks!

@alnr alnr closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants