fix: batch identity created event #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
reviewed
Sep 18, 2024
hperl
force-pushed
the
hperl/fix-batch-create-event
branch
from
f1c381c to
384339f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4111 +/- ##
==========================================
- Coverage 78.63% 78.61% -0.03%
==========================================
Files 377 377
Lines 26980 26985 +5
==========================================
- Hits 21217 21213 -4
- Misses 4153 4160 +7
- Partials 1610 1612 +2 ☔ View full report in Codecov by Sentry. |
alnr
approved these changes
Sep 18, 2024
zepatrik
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the emission of events on identity creation in combination with partial failures.