-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change method=profile:back
to screen=previous
#4119
Conversation
BREAKING CHANGE: When using two-step registration, it was previously possible to send `method=profile:back` to get to the previous screen. This feature was not documented in the SDK API yet. Going forward, please instead use `screen=previous`.
Would it be possible to additionally unify the behavior between login and registration? Right now login provides But I believe this is some amount of additional work. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4119 +/- ##
==========================================
+ Coverage 78.63% 78.65% +0.01%
==========================================
Files 377 377
Lines 26942 26942
==========================================
+ Hits 21185 21190 +5
+ Misses 4146 4142 -4
+ Partials 1611 1610 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
That is kind of correct, I wanted to add a back button but decided against it due to time constraints, and used the identifier_first node as sort of a "workaround". But it's not good, because it adds an implicit dependency on this node. I'm not entirely sure how to best handle this. Ideally we would have something like @jonas-jonas wdyt? |
BREAKING CHANGE: When using two-step registration, it was previously possible to send
method=profile:back
to get to the previous screen. This feature was not documented in the SDK API yet. Going forward, please instead usescreen=previous
.Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments