feat: enable new-style OIDC state generation #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4121 +/- ##
==========================================
- Coverage 78.63% 78.62% -0.01%
==========================================
Files 377 377
Lines 26942 26911 -31
==========================================
- Hits 21185 21158 -27
+ Misses 4146 4144 -2
+ Partials 1611 1609 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aeneasr
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #4078 and #4009 and https://github.com/ory-corp/cloud/issues/6913
This enables the AEAD state generation for OIDC, which in turn is required to actually use PKCE (we store the PKCE verifier in the state). Old state code was removed, and tests simplified to only test the new state mechanism. Hence the deleted snapshots, which were added in #4078 and are now obsolete.