-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Line v2.1 OIDC provider and update related conf… #4240
base: master
Are you sure you want to change the base?
Conversation
…igurations Update provider_line_2_1.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! Could you please also add to the docs a guide for Line? See here for an example: ory/docs#1693
Sorry for the long wait on your PR and congrats to your first submission! :)
Hello! Thank you very much for this @jack-r-hong ❤️ In order to contribute, here is the documentation PR ory/docs#2006 @aeneasr |
Hello, this is my first time contributing code. If you have any suggestions, please feel free to let me know. For OIDC Line Login, you only need to add id_token_key_type=JWK in the exchange step to issue tokens in HS256 format.
Related issue(s)
#1116
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments