Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show oidc subject in login hints #4264

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Jan 10, 2025

In some configurations, if the identity only has an OIDC credential, the login hint message would contain an OIDC identifier including the subject, which is useless to the user.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas requested review from aeneasr and a team as code owners January 10, 2025 11:24
@jonas-jonas jonas-jonas self-assigned this Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.59%. Comparing base (23f3232) to head (baa077f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
identity/manager.go 52.63% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4264      +/-   ##
==========================================
- Coverage   78.61%   78.59%   -0.03%     
==========================================
  Files         381      381              
  Lines       27385    27376       -9     
==========================================
- Hits        21528    21515      -13     
- Misses       4237     4239       +2     
- Partials     1620     1622       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas merged commit b95fd3f into master Jan 10, 2025
31 of 32 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/oidcIdentifierInLoginHints branch January 10, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants