fix: force account selection to improve user login on gh and google

[aeneasr]

See ory/elements#340

Related issue(s)

Checklist

• I have read the contributing guidelines.
• I have referenced an issue containing the design document if my change
  introduces a new feature.
• I am following the
  contributing code guidelines.
• I have read the security policy.
• I confirm that this pull request does not address a security
  vulnerability. If this pull request addresses a security vulnerability, I
  confirm that I got the approval (please contact
  [email protected]) from the maintainers to push
  the changes.
• I have added tests that prove my fix is effective or that my feature
  works.
• I have added or changed the documentation.

Further Comments

[jonas-jonas]

Should we force this on all users? Or make it configurable if someone requests it?

[aeneasr]

It will make the double redirect worse in oidc, but there is this PR which improves that, we just need it reviewed and merged: #4064

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.59%. Comparing base (d4f96ce) to head (1611707).
Report is 23 commits behind head on master.

Files with missing lines	Patch %	Lines
selfservice/strategy/oidc/provider_github.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4280      +/-   ##
==========================================
- Coverage   78.59%   78.59%   -0.01%     
==========================================
  Files         381      381              
  Lines       27372    27373       +1     
==========================================
  Hits        21514    21514              
- Misses       4235     4236       +1     
  Partials     1623     1623              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[David-Wobrock]

It will make the double redirect worse in oidc, but there is this PR which improves that, we just need it reviewed and merged: #4064

Oh yeah, I'd love that ❤️ hihi

---

Btw, this is already possible with #3276, isn't it? 🤔
At least we always send prompt=select_account on Google social sign-in with our self-hosted Kratos.

I mean, you might have good reasons to apply it by default all the time, but it sounds like something that could remain configurable :)