Skip to content

Commit

Permalink
perf: add icon before item contains children
Browse files Browse the repository at this point in the history
  • Loading branch information
orzyyyy committed Oct 7, 2019
1 parent ad18ea4 commit fd4d929
Show file tree
Hide file tree
Showing 3 changed files with 362 additions and 2 deletions.
348 changes: 348 additions & 0 deletions src/canvas/__tests__/__snapshots__/Canvas.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1461,6 +1461,122 @@ exports[`Canvas Canvas renders correctly 1`] = `
onContextMenu={[Function]}
onWheel={[Function]}
>
<Plus>
<AntdIcon
icon={
Object {
"icon": Object {
"attrs": Object {
"focusable": "false",
"viewBox": "64 64 896 896",
},
"children": Array [
Object {
"attrs": Object {},
"children": Array [
Object {
"attrs": Object {},
"tag": "style",
},
],
"tag": "defs",
},
Object {
"attrs": Object {
"d": "M482 152h60q8 0 8 8v704q0 8-8 8h-60q-8 0-8-8V160q0-8 8-8z",
},
"tag": "path",
},
Object {
"attrs": Object {
"d": "M176 474h672q8 0 8 8v60q0 8-8 8H176q-8 0-8-8v-60q0-8 8-8z",
},
"tag": "path",
},
],
"tag": "svg",
},
"name": "plus",
"theme": "outline",
}
}
>
<span
aria-label="plus"
className="anticon anticon-plus"
role="img"
>
<IconReact
className=""
icon={
Object {
"icon": Object {
"attrs": Object {
"focusable": "false",
"viewBox": "64 64 896 896",
},
"children": Array [
Object {
"attrs": Object {},
"children": Array [
Object {
"attrs": Object {},
"tag": "style",
},
],
"tag": "defs",
},
Object {
"attrs": Object {
"d": "M482 152h60q8 0 8 8v704q0 8-8 8h-60q-8 0-8-8V160q0-8 8-8z",
},
"tag": "path",
},
Object {
"attrs": Object {
"d": "M176 474h672q8 0 8 8v60q0 8-8 8H176q-8 0-8-8v-60q0-8 8-8z",
},
"tag": "path",
},
],
"tag": "svg",
},
"name": "plus",
"theme": "outline",
}
}
>
<svg
aria-hidden="true"
className=""
data-icon="plus"
fill="currentColor"
focusable="false"
height="1em"
key="svg-plus"
viewBox="64 64 896 896"
width="1em"
>
<defs
key="svg-plus-svg-0"
>
<style
key="svg-plus-svg-0-defs-0"
/>
</defs>
<path
d="M482 152h60q8 0 8 8v704q0 8-8 8h-60q-8 0-8-8V160q0-8 8-8z"
key="svg-plus-svg-1"
/>
<path
d="M176 474h672q8 0 8 8v60q0 8-8 8H176q-8 0-8-8v-60q0-8 8-8z"
key="svg-plus-svg-2"
/>
</svg>
</IconReact>
</span>
</AntdIcon>
</Plus>
test4
</div>
</NinoZone>
Expand Down Expand Up @@ -1687,6 +1803,122 @@ exports[`Canvas Canvas renders correctly 1`] = `
onContextMenu={[Function]}
onWheel={[Function]}
>
<Plus>
<AntdIcon
icon={
Object {
"icon": Object {
"attrs": Object {
"focusable": "false",
"viewBox": "64 64 896 896",
},
"children": Array [
Object {
"attrs": Object {},
"children": Array [
Object {
"attrs": Object {},
"tag": "style",
},
],
"tag": "defs",
},
Object {
"attrs": Object {
"d": "M482 152h60q8 0 8 8v704q0 8-8 8h-60q-8 0-8-8V160q0-8 8-8z",
},
"tag": "path",
},
Object {
"attrs": Object {
"d": "M176 474h672q8 0 8 8v60q0 8-8 8H176q-8 0-8-8v-60q0-8 8-8z",
},
"tag": "path",
},
],
"tag": "svg",
},
"name": "plus",
"theme": "outline",
}
}
>
<span
aria-label="plus"
className="anticon anticon-plus"
role="img"
>
<IconReact
className=""
icon={
Object {
"icon": Object {
"attrs": Object {
"focusable": "false",
"viewBox": "64 64 896 896",
},
"children": Array [
Object {
"attrs": Object {},
"children": Array [
Object {
"attrs": Object {},
"tag": "style",
},
],
"tag": "defs",
},
Object {
"attrs": Object {
"d": "M482 152h60q8 0 8 8v704q0 8-8 8h-60q-8 0-8-8V160q0-8 8-8z",
},
"tag": "path",
},
Object {
"attrs": Object {
"d": "M176 474h672q8 0 8 8v60q0 8-8 8H176q-8 0-8-8v-60q0-8 8-8z",
},
"tag": "path",
},
],
"tag": "svg",
},
"name": "plus",
"theme": "outline",
}
}
>
<svg
aria-hidden="true"
className=""
data-icon="plus"
fill="currentColor"
focusable="false"
height="1em"
key="svg-plus"
viewBox="64 64 896 896"
width="1em"
>
<defs
key="svg-plus-svg-0"
>
<style
key="svg-plus-svg-0-defs-0"
/>
</defs>
<path
d="M482 152h60q8 0 8 8v704q0 8-8 8h-60q-8 0-8-8V160q0-8 8-8z"
key="svg-plus-svg-1"
/>
<path
d="M176 474h672q8 0 8 8v60q0 8-8 8H176q-8 0-8-8v-60q0-8 8-8z"
key="svg-plus-svg-2"
/>
</svg>
</IconReact>
</span>
</AntdIcon>
</Plus>
test5
</div>
</NinoZone>
Expand Down Expand Up @@ -2784,6 +3016,122 @@ exports[`Canvas Canvas renders correctly 2`] = `
onContextMenu={[Function]}
onWheel={[Function]}
>
<Plus>
<AntdIcon
icon={
Object {
"icon": Object {
"attrs": Object {
"focusable": "false",
"viewBox": "64 64 896 896",
},
"children": Array [
Object {
"attrs": Object {},
"children": Array [
Object {
"attrs": Object {},
"tag": "style",
},
],
"tag": "defs",
},
Object {
"attrs": Object {
"d": "M482 152h60q8 0 8 8v704q0 8-8 8h-60q-8 0-8-8V160q0-8 8-8z",
},
"tag": "path",
},
Object {
"attrs": Object {
"d": "M176 474h672q8 0 8 8v60q0 8-8 8H176q-8 0-8-8v-60q0-8 8-8z",
},
"tag": "path",
},
],
"tag": "svg",
},
"name": "plus",
"theme": "outline",
}
}
>
<span
aria-label="plus"
className="anticon anticon-plus"
role="img"
>
<IconReact
className=""
icon={
Object {
"icon": Object {
"attrs": Object {
"focusable": "false",
"viewBox": "64 64 896 896",
},
"children": Array [
Object {
"attrs": Object {},
"children": Array [
Object {
"attrs": Object {},
"tag": "style",
},
],
"tag": "defs",
},
Object {
"attrs": Object {
"d": "M482 152h60q8 0 8 8v704q0 8-8 8h-60q-8 0-8-8V160q0-8 8-8z",
},
"tag": "path",
},
Object {
"attrs": Object {
"d": "M176 474h672q8 0 8 8v60q0 8-8 8H176q-8 0-8-8v-60q0-8 8-8z",
},
"tag": "path",
},
],
"tag": "svg",
},
"name": "plus",
"theme": "outline",
}
}
>
<svg
aria-hidden="true"
className=""
data-icon="plus"
fill="currentColor"
focusable="false"
height="1em"
key="svg-plus"
viewBox="64 64 896 896"
width="1em"
>
<defs
key="svg-plus-svg-0"
>
<style
key="svg-plus-svg-0-defs-0"
/>
</defs>
<path
d="M482 152h60q8 0 8 8v704q0 8-8 8h-60q-8 0-8-8V160q0-8 8-8z"
key="svg-plus-svg-1"
/>
<path
d="M176 474h672q8 0 8 8v60q0 8-8 8H176q-8 0-8-8v-60q0-8 8-8z"
key="svg-plus-svg-2"
/>
</svg>
</IconReact>
</span>
</AntdIcon>
</Plus>
test5
</div>
</NinoZone>
Expand Down
6 changes: 6 additions & 0 deletions src/canvas/core.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ export interface CoordinatesProps {
x: number;
y: number;
}
export interface CommonProps {
children?: string[];
style?: React.CSSProperties;
childStyle?: React.CSSProperties;
className?: string;
}
export type DataSource = {
position?: {
[key: string]: CoordinatesProps;
Expand Down
Loading

0 comments on commit fd4d929

Please sign in to comment.