Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to restrict asset downloads to logged-in users #6082

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

Martchus
Copy link
Contributor

  • Disallow unauthenticated access to assets in web application routes
  • Does NOT cover access served via Apache/NGINX
  • Does NOT cover adjusting the cache service and additional tooling like the openqa-clone-job script
  • See https://progress.opensuse.org/issues/170380

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (60a7833) to head (4c8ed39).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6082   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         396      396           
  Lines       39527    39548   +21     
=======================================
+ Hits        39127    39148   +21     
  Misses        400      400           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty clean. Can openQA jobs on workers still access assets during job runs, e.g. to read a iso or qcow file needed for test execution?

etc/openqa/openqa.ini Outdated Show resolved Hide resolved
@Martchus
Copy link
Contributor Author

Can openQA jobs on workers still access assets during job runs, e.g. to read a iso or qcow file needed for test execution?

No, they cannot (except via NFS which is probably completely out of scope). The cache service is one of many open points I added on https://progress.opensuse.org/issues/174154. With Martchus@32e1b30 (which is referenced in the progress issue) this would likely work.

@okurz
Copy link
Member

okurz commented Dec 12, 2024

Can openQA jobs on workers still access assets during job runs, e.g. to read a iso or qcow file needed for test execution?

No, they cannot (except via NFS which is probably completely out of scope). The cache service is one of many open points I added on https://progress.opensuse.org/issues/174154. With Martchus@32e1b30 (which is referenced in the progress issue) this would likely work.

Well, worker instances having direct access to the openQA base dir still work which includes cases like worker instances running on the same host as the webUI – which can even be considered the default for tiny instances – as well as when having access over NFS. How about you state that in the explanatory comment in openqa.ini. Then I guess we can merge this limited-scope feature

* Disallow unauthenticated access to assets in web application routes
* Does NOT cover access served via Apache/NGINX
* Does NOT cover adjusting the cache service and additional tooling like
  the `openqa-clone-job` script
* See https://progress.opensuse.org/issues/170380
@Martchus Martchus force-pushed the asset-auth-webapp-only branch from 9296833 to 4c8ed39 Compare December 12, 2024 16:11
@mergify mergify bot merged commit e041d9c into os-autoinst:master Dec 13, 2024
46 checks passed
@Martchus Martchus deleted the asset-auth-webapp-only branch December 13, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants