WIP Fully cover scripts/dewebsockify by tests #6083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make scripts/dewebsockify fully covered by tests. Related Progress Ticket: https://progress.opensuse.org/issues/174232
okurz
requested changes
Dec 16, 2024
There was a problem hiding this comment.
err, I'm confused. https://progress.opensuse.org/issues/174232 is about os-autoinst, you add to openQA?
Martchus
requested changes
Dec 16, 2024
Comment on lines
+120
to
+125
| subtest 'upgrade failure' => sub { | ||
| $t->tx($t->ua->start($t->ua->build_websocket_tx('ws://invalid'))); | ||
| $t->status_is(101, 'Initial HTTP handshake for WebSocket returns a valid protocol switch'); | ||
| $t->finished_ok(1006, 'WebSocket closed with status code 1006 (abnormal closure)'); | ||
| $t->content_like(qr/Unable to upgrade to WebSocket connection/, 'Error message logged on WebSocket upgrade failure'); | ||
| }; |
There was a problem hiding this comment.
This test is about the websocket server of the web UI and has nothing to do with dewebsockify which the ticket is about.
Unless I'm overlooking something this tests also only tests the behavior of Mojolicious itself so that's on its own also not very useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make scripts/dewebsockify fully covered by tests.
Related Progress Ticket: https://progress.opensuse.org/issues/174232