Check for existing job groups during openqa-load-templates #6095
+24
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6095 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 396 396
Lines 39549 39558 +9
=======================================
+ Hits 39149 39158 +9
Misses 400 400 ☔ View full report in Codecov by Sentry. |
okurz
requested changes
Jan 2, 2025
Wabri
requested changes
Jan 3, 2025
r-richardson
force-pushed
the
174808_template_dump
branch
from
703585d to
91a0641
Compare
okurz
requested changes
Jan 3, 2025
r-richardson
force-pushed
the
174808_template_dump
branch
from
91a0641 to
9835ecc
Compare
okurz
requested changes
Jan 7, 2025
r-richardson
force-pushed
the
174808_template_dump
branch
5 times, most recently
from
5e4e862 to
16ace53
Compare
okurz
approved these changes
Jan 7, 2025
r-richardson
force-pushed
the
174808_template_dump
branch
2 times, most recently
from
6200baf to
97d34ec
Compare
The `openqa-load-templates` script now checks if a job groups is already present when importing new template data. If a group already exists, there will be no attempt of creating it, but associated templates will still be loaded if the `--update` option is provided. If the `--update` option is not provided, and a duplicate job group is found, the import will fail. Related Issue: https://progress.opensuse.org/issues/174808
Wabri
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
openqa-load-templatesscript now checks if a job groups is already present when importing new template data. If a group already exists, there will be no attempt of creating it, but associated templates will still be loaded if the--updateoption is provided.If the
--updateoption is not provided, and a duplicate job group is found, the import will fail.Related Issue: https://progress.opensuse.org/issues/174808