Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: Set LTP_TAINT_EXPECTED for various memory tests #511

Conversation

pevik
Copy link
Contributor

@pevik pevik commented Aug 26, 2024

ltp_mm, ltp_mm_oom, ltp_numa, ltp_uevent on x86_64 need LTP_TAINT_EXPECTED=0x200 to avoid Kernel issued warning.

aarch64 and ppc64le don't issue these taints, s390x don't test them, thus not adding this setup.

ltp_mm is tested also on i586, where it's not needed atm, but overcommit_memory0[1-6] fail. Likely, once these tests are fixed, they will issue the same taint, thus set it now.

See:

@Vogtinator @mdoucha FYI

ltp_mm, ltp_mm_oom, ltp_numa, ltp_uevent on x86_64 need
LTP_TAINT_EXPECTED=0x200 to avoid Kernel issued warning.

aarch64 and ppc64le don't issue these taints, s390x don't test them,
thus not adding this setup.

ltp_mm is tested also on i586, where it's not needed atm,
but overcommit_memory0[1-6] fail. Likely, once these tests are fixed,
they will issue the same taint, thus set it now.

Signed-off-by: Petr Vorel <[email protected]>
@Vogtinator
Copy link
Member

IMO this should be done in the testsuite or test code and not the jobgroups.

Is there ever a case where this taint is not ok?

@pevik
Copy link
Contributor Author

pevik commented Aug 26, 2024

@Vogtinator

  1. This is setup just for some archs (in the testsuite the setup is for all architectures). The reason, why this is done only for x86_64 and i586 is in the git commit message and in PR description.
  2. We have lost some setup in the past DB data failure and following recovery from the backup, that's why we use this approach in both o3 and osd. We would prefer to have the same approach for kernel tests on both o3 and osd (I've been forced to do things differently for o3 and osd due different opinions of the reviewers and it's not really optimal for the team). Also we already merged some setup in LTP_TAINT_EXPECTED. Having in openQA code is_opensuse + comments that for osd we solve that in jobgroups yaml is not really optimal.

@Vogtinator
Copy link
Member

This is setup just for some archs (in the testsuite the setup is for all architectures). The reason, why this is done only for x86_64 and i586 is in the git commit message and in PR description.

Yes, which I don't really agree with - just accept the taint for all architectures?

Having in openQA code is_opensuse + comments that for osd we solve that in jobgroups yaml is not really optimal.

osd and o3 use the same distri for testing, so to fix it in one place it can be done there.

@pevik
Copy link
Contributor Author

pevik commented Aug 26, 2024

Well, first I was incorrect, it's a real bug: https://bugzilla.suse.com/show_bug.cgi?id=1229671 (I thought it was caused by out of memory tests), thus closing it + I will tag the tests.

@mdoucha
Copy link

mdoucha commented Aug 26, 2024

Is there ever a case where this taint is not ok?

I'd say there is no case where this taint would be OK. All kernel warnings need to be investigated and fixed. In this case, it's a QEMU configuration error. QEMU_NUMA=1 requires QEMUSOCKETS=%QEMUCPUS%. When I add the missing QEMUSOCKETS, the warning goes away.
https://openqa.opensuse.org/tests/4435106

@pevik pevik closed this Aug 26, 2024
@Vogtinator
Copy link
Member

I thought this was about https://progress.opensuse.org/issues/165587#change-832358, but that's actually a different taint:

Kernel taint: 0x3000

Unexpected taint:
- Unsigned module was loaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants