Skip to content

Commit

Permalink
Prevent the use of assert_screen for console based modules
Browse files Browse the repository at this point in the history
  • Loading branch information
cedvid committed Mar 7, 2024
1 parent 0e05092 commit eb38006
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
6 changes: 5 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ test-spec:
tools/update_spec --check

.PHONY: test-static
test-static: tidy-check test-yaml-valid test-modules-in-yaml-schedule test-merge test-dry test-no-wait_idle test-deleted-renamed-referenced-files test-unused-modules-changed test-soft_failure-no-reference test-spec test-invalid-syntax test-code-style test-metadata test_pod_whitespace_rule test_pod_errors
test-static: tidy-check test-yaml-valid test-modules-in-yaml-schedule test-merge test-dry test-no-wait_idle test-deleted-renamed-referenced-files test-unused-modules-changed test-soft_failure-no-reference test-spec test-invalid-syntax test-code-style test-metadata test_pod_whitespace_rule test_pod_errors test-console-based-modules

.PHONY: test
ifeq ($(TESTS),compile)
Expand Down Expand Up @@ -160,3 +160,7 @@ test-code-style:
.PHONY: test-isotovideo
test-isotovideo:
tools/test_isotovideo

.PHONY: test-console-based-modules
test-console-based-modules:
@! git --no-pager grep --files-with-matches -E 'use base ("|\')consoletest' "*tests/*.pm" | xargs grep -q 'assert_screen'
5 changes: 5 additions & 0 deletions tests/test.pm
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
use base 'consoletest'

assert_screen


0 comments on commit eb38006

Please sign in to comment.