Prepare two synchronized machines to test PCW #17429

ilausuch · 2023-07-17T09:44:09Z

PCW is executed in a microos and is setup using ansible. This PR creates the environment for two VMs to test the ansible playbooks and selenium tests.

The microos is ready with all the needed packages.

Related ticket: https://progress.opensuse.org/issues/130144
Verification run:
https://openqa.suse.de/tests/11624244
https://openqa.suse.de/tests/11624245

pdostal · 2023-07-17T10:12:30Z

tests/publiccloud/pcw_client.pm

+    zypper_call('in -y iputils git');
+
+    assert_script_run('mkdir /root/.ssh');
+    assert_script_run('curl -f -v ' . autoinst_url . '/data/slenkins/ssh/id_rsa > /root/.ssh/id_rsa');


Please generate new keys and put them into data/publiccloud/pcw/.

We should not use pre-generated keys in test runs, but rather generate new transient keys for each test run.

data/publiccloud/pcw/sshd_config

tests/publiccloud/pcw_client.pm

tests/publiccloud/pcw_target.pm

pdostal · 2023-07-17T10:20:24Z

tests/publiccloud/pcw_target.pm

+    assert_script_run('zypper ar http://download.suse.de/ibs/SUSE:/CA/openSUSE_Tumbleweed/ SUSE_CA');
+    assert_script_run('zypper --gpg-auto-import-keys ref');
+    assert_script_run('transactional-update -n -c pkg install ca-certificates-suse htop iftop iotop atop telnet nmap jq git rsync wget parted tcpdump screen sqlite3 fortune iputils nginx dehydrated dehydrated-nginx podman podman-cni-config cockpit cockpit-podman toolbox python3-selinux');
+    process_reboot(trigger => 1);


This is already done in Ansible.

yes I would expect only python3 install here , all other things should happen via ansible script if we currently missing something we need to add this into ansible script not here

do you mean python3-selinux?
why python3 shouldn't be in the other repo?

Try to remove this as a whole.

Try to remove this as a whole.

no we do need to install python on target ( it is not available by default on MicroOS and requirement by ansible )

do you mean python3-selinux?

no I mean that except installation of python package target should not be changed by the test at all , no addition of extra repos , no extra packages installation . the whole point of this test is to check that on clean VM this ansible playbook can create workable system. With set of this zypper addrepo ... / zypper in ... calls you removing "on clean VM"

Anton, there is no Python in the list right now. Isn't Python on MicroOS by default? And if it's not, then Ivan will find out latest.

Anton, there is no Python in the list right now. Isn't Python on MicroOS by default? And if it's not, then Ivan will find out latest.

two times when I was doing this setup manually I was forced to install python , but you can double-check with someone who knows MicroOS better

python3 is not present by default I think. However this things are moving rather quickly, it's anyways good to install it explicitly, just to ensure it's present.

lib/network_utils.pm

asmorodskyi · 2023-07-17T10:28:49Z

at least for me pcw_client is a bit confusing . I would call it ansible_client and ansible_target . After all playbook will install not only PCW there

grisu48 · 2023-07-18T11:44:46Z

Do we really need selenium? Wouldn't it be sufficient to fetch the /health.json from the newly installed PCW instance and check if it returns the expected status object?

{"status": "ok"}

asmorodskyi · 2023-07-18T11:53:10Z

Do we really need selenium?

I think this discussion goes far away from this PR . this is something what we will decide later on
depending what expected coverage for the test . I think at the end we will have several tests based on that some of them will concentrate covering ansible playbook and they won't need selenium . Others will aim give better coverage of PCW functionality and here we might use selenium

github-actions · 2023-07-18T13:51:04Z

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

lib/network_utils.pm

ricardobranco777 · 2023-07-18T16:37:18Z

Do we really need selenium? Wouldn't it be sufficient to fetch the /health.json from the newly installed PCW instance and check if it returns the expected status object?
{"status": "ok"}

I do believe that Selenium tests would fit nicely here, because the one that we have in GitHub interacts directly with Django, and in this case we have Nginx + Django.

@ilausuch (or anyone planning to add such a test):

Example code on how to run it in openQA: https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/tests/ha/hawk_gui.pm
Basic Selenium test for pcw: https://github.com/SUSE/pcw/blob/master/tests/test_webui.py

OPTIONAL: Run the tests using a Docker image like it's done with HAWK:

Example Dockerfile: https://github.com/ClusterLabs/hawk/blob/master/e2e_test/Dockerfile
Documentation on how to publish the image in registry.opensuse.org: https://confluence.suse.com/display/qasle/Automatic+publishing+of+Docker+images+from+a+Git+repository+using+OpenBuildService

lib/network_utils.pm

tests/publiccloud/ansible_target.pm

tests/publiccloud/ansible_client.pm

asmorodskyi

LGTM

asmorodskyi · 2023-07-20T10:48:53Z

lib/main_publiccloud.pm

+            loadtest 'boot/boot_to_desktop';
+            loadtest 'publiccloud/ansible_client';
+        } elsif (get_var('PUBLIC_CLOUD_PCW_TARGET')) {
+            loadtest 'microos/disk_boot';


it won't work like this see line 201

if (check_var('PUBLIC_CLOUD_PREPARE_TOOLS', 1)) { load_create_publiccloud_tools_image(); } elsif (check_var('PUBLIC_CLOUD_TOOLS_CLI', 1)) { load_publiccloud_cli_tools(); } elsif (get_var('PUBLIC_CLOUD_PCW_TARGET')) { loadtest 'microos/disk_boot'; loadtest 'publiccloud/ansible_target'; } else { loadtest 'boot/boot_to_desktop'; if (get_var('PUBLIC_CLOUD_MIGRATION')) { my $args = OpenQA::Test::RunArgs->new(); loadtest('publiccloud/upload_image', run_args => $args); loadtest('publiccloud/migration', run_args => $args); } elsif (check_var('PUBLIC_CLOUD_DOWNLOAD_TESTREPO', 1)) { load_publiccloud_download_repos(); } elsif (get_var('PUBLIC_CLOUD_QAM')) { load_maintenance_publiccloud_tests(); } elsif (get_var('PUBLIC_CLOUD_PCW_CLIENT')) { loadtest 'publiccloud/ansible_client'; }

Yes, understood. In my wayt a previous loadtest is added

pdostal · 2023-07-26T07:08:16Z

lib/main_micro_alp.pm

+    if (check_var('PUBLIC_CLOUD_ANSIBLE_CLIENT', 1)) {
+        loadtest 'boot/boot_to_desktop';
+        loadtest 'publiccloud/ansible_client';
+    }
+    elsif (check_var('PUBLIC_CLOUD_ANSIBLE_TARGET', 1)) {
+        loadtest 'microos/disk_boot';
+        loadtest 'publiccloud/ansible_target';
+    }


I would move this out of load_slem_on_pc_tests().

pdostal · 2023-07-26T07:18:22Z

tests/publiccloud/ansible_client.pm

+    zypper_call('in -y iputils git');
+
+    assert_script_run('mkdir /root/.ssh');
+    assert_script_run('curl -f -v ' . autoinst_url . '/data/slenkins/ssh/id_rsa > /root/.ssh/id_rsa');


Please either allow password login and generate the key in the test or at least generate our own key in data/publiccloud/

Let's please not have pre-generated keys as they always expose a certain security risk. Unless really really really necessary, let's generate per-test key pairs.

Let's please not have pre-generated keys as they always expose a certain security risk. Unless really really really necessary, let's generate per-test key pairs.

IMHO it is too much . we can not apply common security rules into short living test VM running in internal network . Generating per-test key pairs coming with very high price -> in case debug is needed you can access VM only via VNC

if we really want to care about security of test VM running on internal network let's hide ssh key in worker config so it will be protected on same level as some other info which has much much more value

PCW is executed in a microos and is setup using ansible. This PR creates the environment for two VMs to test the ansible playbooks and selenium tests. The microos is ready with all the needed packages. https://progress.opensuse.org/issues/130144

ilausuch · 2023-07-28T09:20:44Z

We decided to move in an other direction. See the ticket

ilausuch requested review from pdostal, grisu48, asmorodskyi, ricardobranco777 and m-dati as code owners July 17, 2023 09:44

pdostal reviewed Jul 17, 2023

View reviewed changes

data/publiccloud/pcw/sshd_config Outdated Show resolved Hide resolved

pdostal reviewed Jul 17, 2023

View reviewed changes

tests/publiccloud/pcw_client.pm Outdated Show resolved Hide resolved

ilausuch force-pushed the test_pcw branch from 63f0432 to 99131d5 Compare July 17, 2023 10:15

pdostal reviewed Jul 17, 2023

View reviewed changes

asmorodskyi reviewed Jul 17, 2023

View reviewed changes

lib/network_utils.pm Outdated Show resolved Hide resolved

ilausuch force-pushed the test_pcw branch from 99131d5 to f271bec Compare July 17, 2023 11:19

ilausuch added the WIP Work in progress label Jul 17, 2023

ilausuch force-pushed the test_pcw branch 6 times, most recently from b81c1cd to f507064 Compare July 18, 2023 11:24

ilausuch force-pushed the test_pcw branch from f507064 to f210760 Compare July 18, 2023 13:50

asmorodskyi reviewed Jul 18, 2023

View reviewed changes

lib/network_utils.pm Outdated Show resolved Hide resolved

ricardobranco777 reviewed Jul 18, 2023

View reviewed changes

lib/network_utils.pm Outdated Show resolved Hide resolved

tests/publiccloud/ansible_target.pm Outdated Show resolved Hide resolved

asmorodskyi reviewed Jul 19, 2023

View reviewed changes

tests/publiccloud/ansible_client.pm Outdated Show resolved Hide resolved

ilausuch force-pushed the test_pcw branch 2 times, most recently from ac4cf5e to 6311e33 Compare July 19, 2023 11:43

asmorodskyi approved these changes Jul 20, 2023

View reviewed changes

ilausuch force-pushed the test_pcw branch 4 times, most recently from f0455a0 to 4cc47e8 Compare July 20, 2023 10:23

asmorodskyi reviewed Jul 20, 2023

View reviewed changes

ilausuch force-pushed the test_pcw branch 8 times, most recently from 59be9e8 to d7f9857 Compare July 25, 2023 13:27

ilausuch requested review from mloviska and jlausuch as code owners July 25, 2023 13:27

pdostal reviewed Jul 26, 2023

View reviewed changes

ilausuch force-pushed the test_pcw branch 2 times, most recently from b4223fa to 3e67a9a Compare July 26, 2023 12:25

ilausuch force-pushed the test_pcw branch 5 times, most recently from b4e5146 to d528b0c Compare July 27, 2023 10:52

Public CLoud: Schedule Ansible client as SLE and target as SLEM

7a54b65

ilausuch force-pushed the test_pcw branch from d528b0c to 7a54b65 Compare July 27, 2023 11:01

ilausuch closed this Jul 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare two synchronized machines to test PCW #17429

Prepare two synchronized machines to test PCW #17429

ilausuch commented Jul 17, 2023 •

edited

Loading

pdostal Jul 17, 2023

grisu48 Jul 18, 2023

pdostal Jul 17, 2023

asmorodskyi Jul 17, 2023

ilausuch Jul 17, 2023

pdostal Jul 17, 2023

asmorodskyi Jul 17, 2023 •

edited

Loading

pdostal Jul 17, 2023

asmorodskyi Jul 17, 2023

grisu48 Jul 18, 2023

asmorodskyi commented Jul 17, 2023

grisu48 commented Jul 18, 2023

asmorodskyi commented Jul 18, 2023

github-actions bot commented Jul 18, 2023

ricardobranco777 commented Jul 18, 2023 •

edited

Loading

asmorodskyi left a comment

asmorodskyi Jul 20, 2023

asmorodskyi Jul 20, 2023

ilausuch Jul 20, 2023

pdostal Jul 26, 2023

pdostal Jul 26, 2023

grisu48 Jul 27, 2023

asmorodskyi Jul 27, 2023

asmorodskyi Jul 27, 2023

ilausuch commented Jul 28, 2023

Prepare two synchronized machines to test PCW #17429

Prepare two synchronized machines to test PCW #17429

Conversation

ilausuch commented Jul 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asmorodskyi Jul 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asmorodskyi commented Jul 17, 2023

grisu48 commented Jul 18, 2023

asmorodskyi commented Jul 18, 2023

github-actions bot commented Jul 18, 2023

ricardobranco777 commented Jul 18, 2023 • edited Loading

asmorodskyi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ilausuch commented Jul 28, 2023

ilausuch commented Jul 17, 2023 •

edited

Loading

asmorodskyi Jul 17, 2023 •

edited

Loading

ricardobranco777 commented Jul 18, 2023 •

edited

Loading