pc: Fix version of Azure Terraform provider for NFS test #17770
Conversation
ricardobranco777
requested review from
pdostal,
grisu48 and
asmorodskyi
as code owners
ricardobranco777
force-pushed
the
fix_nfs
branch
from
4a68363
to
d0fe3a0
Compare
| @@ -1,7 +1,7 @@ | |||
| terraform { | |||
| required_providers { | |||
| azurerm = { | |||
| version = ">= 3.2.0" | |||
| version = "= 3.2.0" | |||
There was a problem hiding this comment.
I am not sure what was your intention . this change basically downgrade azurerm to version 3.2.0 . I don't think that it is good idea . Currently failed run was using 3.72 latest passed was on 3.70 so as hotfix we may rollback to THAT version
There was a problem hiding this comment.
as long term we need to find what was changed in latest version of plugin and probably update config to new format
There was a problem hiding this comment.
Is there "new format"? And is there even any significant change in the provider affecting us?
Or can we just upgrade, test it, maybe do major tweak of our existing files and be done with it?
There was a problem hiding this comment.
I can not answer this questions without running test run . this is why we have version of provider locked here because from time terraform providers changing their format so our old profiles will start to fail . We have two options here :
- remove this artificial limitation and learn about this changes from mass failures of all Azure related tests . So we will need to firefight the issue in urgent mode .
- Keep version locked and do from time to time "upgrade cycles" which includes test runs on the latest provider version
I am prefer second option
There was a problem hiding this comment.
Yes, me too. We chose the second option.
I just wanted to say that we should not explicitly see upgrading as problem.
We should upgrade and do some verification runs before merging so we're sure.
ricardobranco777
force-pushed
the
fix_nfs
branch
from
d0fe3a0
to
bc5de24
Compare
|
Go to #17782 |
The NFS test uses the latest Azure Terraform provider. This PR makes it use the same version that we use for the other tests.