Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public Cloud: Use ed25519 in GCP and AWS #18706

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Public Cloud: Use ed25519 in GCP and AWS #18706

merged 1 commit into from
Feb 28, 2024

Conversation

pdostal
Copy link
Member

@pdostal pdostal commented Feb 21, 2024 •
edited
Loading

ricardobranco777
ricardobranco777 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

grisu48
grisu48 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only minor nitpicking detail suggestions

lib/publiccloud/provider.pm Outdated Show resolved Hide resolved
asmorodskyi
asmorodskyi approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardobranco777 ricardobranco777 merged commit 8be5bc0 into os-autoinst:master Feb 28, 2024
10 checks passed
@pdostal pdostal mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraih kraih kraih left review comments

@grisu48 grisu48 grisu48 approved these changes

@ricardobranco777 ricardobranco777 ricardobranco777 approved these changes

@asmorodskyi asmorodskyi asmorodskyi approved these changes

@m-dati m-dati Awaiting requested review from m-dati m-dati is a code owner

@mpagot mpagot Awaiting requested review from mpagot mpagot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pdostal @kraih @grisu48 @ricardobranco777 @asmorodskyi