Provide migration from SLES 12 SP5 to SLES 15 SP4 in aggregated updates

[hjluo]

$${{\color{green}\Huge{\textsf{ Provide migration from SLES 12 SP5 to SLES 15 SP4 in aggregated updates }}}}$$

• Related ticket:
  • 154948
• Related MR:
  • openqa-job-group_96
• Needles:
  • N/A
• Verification run:
  • https://openqa.suse.de/tests/14037539

[rakoenig]

LGTM.

[lemon-suse]

Is this 'regression for addon_products_sle' related with the PR?

[hjluo]

Is this 'regression for addon_products_sle' related with the PR?

cause we've changed the code in addon_products_sle.pm

[hjluo]

there are aprox. 28 repos with updates, but I can only see in patching 20, could you please check that?

I've manually run zypper patch 2 times and it still shows 20 packages patched. the rest may be for the reason that 8 packages were not installed, so even though we have a repo we can't do a patch here.

[hjluo]

You'd better to un-label WIP when already ready for review.

Done.

[lemon-suse]

LGTM.

[jknphy]

we already have one test suite, 'create_hdd_yast_maintenance_desktop', that install the system, I don't get why we are adding a new one here, we should reuse (/fix) the existing one as described in the ticket.

[lemon-suse]

we already have one test suite, 'create_hdd_yast_maintenance_desktop', that install the system, I don't get why we are adding a new one here, we should reuse (/fix) the existing one as described in the ticket.

Yes, we should re-use this 'create_hdd_yast_maintenance_desktop' , while the test on 12SP5 has an issue that can't add unreleased repo, should fix in another ticket.

@hjluo
Besides, it is strange that I found you added de-register in latest VR, https://openqa.suse.de/tests/13964318#step/scc_deregistration/1 I think that is not as expected.

[jknphy]

we already have one test suite, 'create_hdd_yast_maintenance_desktop', that install the system, I don't get why we are adding a new one here, we should reuse (/fix) the existing one as described in the ticket.

Yes, we should re-use this 'create_hdd_yast_maintenance_desktop' , while the test on 12SP5 has an issue that can't add unreleased repo, should fix in another ticket.

@hjluo Besides, it is strange that I found you added de-register in latest VR, https://openqa.suse.de/tests/13964318#step/scc_deregistration/1 I think that is not as expected.

why in another ticket? I don't think it is a good idea duplicate autoyast profile and not fixing in this one, what is the different between both profiles that one add the repos and the other not?

For example this block is not necessary, because sle 12 sp5 doesn't have libyui-rest-api:
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/18756/files#diff-f969ba3f0eca25129917f41599a294bad311508f3f645c8273b0b9b574ebf5d0R222-R230

[lemon-suse]

we already have one test suite, 'create_hdd_yast_maintenance_desktop', that install the system, I don't get why we are adding a new one here, we should reuse (/fix) the existing one as described in the ticket.

Yes, we should re-use this 'create_hdd_yast_maintenance_desktop' , while the test on 12SP5 has an issue that can't add unreleased repo, should fix in another ticket.
@hjluo Besides, it is strange that I found you added de-register in latest VR, https://openqa.suse.de/tests/13964318#step/scc_deregistration/1 I think that is not as expected.

why in another ticket? I don't think it is a good idea duplicate autoyast profile and not fixing in this one, what is the different between both profiles that one add the repos and the other not?

For example this block is not necessary, because sle 12 sp5 doesn't have libyui-rest-api: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/18756/files#diff-f969ba3f0eca25129917f41599a294bad311508f3f645c8273b0b9b574ebf5d0R222-R230

I haven't express clear for my meaning, in fact I just mean there already a ticket created https://progress.opensuse.org/issues/158401 . NP to fix it in this PR, I think need compare the profiles to update.

[lemon-suse]

we already have one test suite, 'create_hdd_yast_maintenance_desktop', that install the system, I don't get why we are adding a new one here, we should reuse (/fix) the existing one as described in the ticket.

Yes, we should re-use this 'create_hdd_yast_maintenance_desktop' , while the test on 12SP5 has an issue that can't add unreleased repo, should fix in another ticket.
@hjluo Besides, it is strange that I found you added de-register in latest VR, https://openqa.suse.de/tests/13964318#step/scc_deregistration/1 I think that is not as expected.

why in another ticket? I don't think it is a good idea duplicate autoyast profile and not fixing in this one, what is the different between both profiles that one add the repos and the other not?

For example this block is not necessary, because sle 12 sp5 doesn't have libyui-rest-api: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/18756/files#diff-f969ba3f0eca25129917f41599a294bad311508f3f645c8273b0b9b574ebf5d0R222-R230

I haven't express clear for my meaning, in fact I just mean there already a ticket created https://progress.opensuse.org/issues/158401 . NP to fix it in this PR, I think need compare the profiles to update.