Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console redirection #18815

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

lpalovsky
Copy link
Contributor

@lpalovsky lpalovsky commented Mar 6, 2024

This PR adds libraries and simple test module for redirecting serial console to remote VM which allows using OpenQA API as it would be running on local worker instance.
It can be used cases like public cloud or VMware based SUT.

@lpalovsky lpalovsky added the WIP Work in progress label Mar 6, 2024
@lpalovsky lpalovsky force-pushed the sdaf_console_redirection branch 7 times, most recently from 2bec08f to 6b121d2 Compare March 6, 2024 14:39
@lpalovsky lpalovsky removed the WIP Work in progress label Mar 6, 2024
@lpalovsky lpalovsky self-assigned this Mar 6, 2024
lib/sles4sap/microsoft_sdaf.pm Outdated Show resolved Hide resolved
lib/sles4sap/microsoft_sdaf.pm Outdated Show resolved Hide resolved
lib/sles4sap/microsoft_sdaf_basetest.pm Outdated Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Outdated Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Outdated Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Outdated Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Outdated Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Outdated Show resolved Hide resolved
lib/sles4sap/microsoft_sdaf.pm Outdated Show resolved Hide resolved
lib/sles4sap/microsoft_sdaf.pm Outdated Show resolved Hide resolved
lib/sles4sap/microsoft_sdaf.pm Outdated Show resolved Hide resolved
lib/sles4sap/microsoft_sdaf.pm Outdated Show resolved Hide resolved
@lpalovsky lpalovsky force-pushed the sdaf_console_redirection branch 4 times, most recently from 19b986a to 467c9c2 Compare March 7, 2024 08:08
Copy link
Contributor

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, comments there are not about code behavior but more about documentation and code style.

@lpalovsky lpalovsky force-pushed the sdaf_console_redirection branch 5 times, most recently from 86f5c1e to 65d3222 Compare March 7, 2024 11:35
@lpalovsky
Copy link
Contributor Author

Latest code tested with mock test module in separate branch:
https://mordor.suse.cz/tests/6583#details
Cathing failure in case of host accepting only ssh key login: https://mordor.suse.cz/tests/6581#step/sdaf_prepare_jumphost/69

@lpalovsky lpalovsky force-pushed the sdaf_console_redirection branch 2 times, most recently from ccf472a to 9e01f37 Compare March 7, 2024 12:23
lib/sles4sap/console_redirection.pm Outdated Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Outdated Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Outdated Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Outdated Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Outdated Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Outdated Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Show resolved Hide resolved
lib/sles4sap/console_redirection.pm Outdated Show resolved Hide resolved
@lpalovsky lpalovsky force-pushed the sdaf_console_redirection branch 3 times, most recently from 1ba9928 to 8818bec Compare March 7, 2024 15:08
@lpalovsky lpalovsky force-pushed the sdaf_console_redirection branch 2 times, most recently from 59536d2 to 16596e5 Compare March 7, 2024 15:25
Copy link
Contributor

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpalovsky lpalovsky merged commit 5f63456 into os-autoinst:master Mar 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants