Cleanup logic improvements #19829
Merged
Cleanup logic improvements #19829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpalovsky
force-pushed
the
sdaf_deployer_vm_cleanup
branch
3 times, most recently
from
83f2ef2
to
f59c7c0
Compare
lpalovsky
force-pushed
the
sdaf_deployer_vm_cleanup
branch
11 times, most recently
from
003c60d
to
c0e2d46
Compare
lpalovsky
commented
Aug 13, 2024
| @@ -9,48 +9,28 @@ | |||
| # Post run hooks are generally disabled during normal module run so the infrastructure persists between test modules. | |||
| # Cleanup is triggered only with B<SDAF_DO_CLEANUP> set to true, which is done by scheduling this module at the end of test flow. | |||
|
|
|||
| use parent 'sles4sap::sap_deployment_automation_framework::basetest'; | |||
There was a problem hiding this comment.
This is probably not crucial, but it might remove some unnecessary inheritance.
lpalovsky
force-pushed
the
sdaf_deployer_vm_cleanup
branch
5 times, most recently
from
b4873c5
to
89ac82d
Compare
lpalovsky
commented
Aug 15, 2024
| @@ -142,7 +142,7 @@ sub az_login { | |||
| assert_script_run("source $temp_file"); | |||
|
|
|||
| my $login_cmd = 'while ! az login --service-principal -u ${ARM_CLIENT_ID} -p ${ARM_CLIENT_SECRET} -t ${ARM_TENANT_ID}; do sleep 10; done'; | |||
| assert_script_run($login_cmd, timeout => 5 * 60); | |||
| assert_script_run($login_cmd, timeout => 30); | |||
There was a problem hiding this comment.
5*60 for login is just too much.
lpalovsky
force-pushed
the
sdaf_deployer_vm_cleanup
branch
from
89ac82d
to
79fe840
Compare
|
LGTM, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds improvements for SDAF cleanup routine:
snapshot based deployer VM cleanup
cleanup behavior at different stages of test failures
removing redundant cleanup code in post fail hook and standard cleanup test module
Related ticket: https://jira.suse.com/browse/TEAM-9459
Verification runs
Successful run:
https://openqaworker15.qa.suse.cz/tests/294657#
Failure before SDAF deployment starts:
Failure before deployer VM is created: