xfstests: Move function to lib util #19869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
SeroSun
changed the title
SeroSun
force-pushed
the
yosun/loadtest_xfstests
branch
from
3709971
to
1fdbc79
Compare
SeroSun
force-pushed
the
yosun/loadtest_xfstests
branch
4 times, most recently
from
ca0fdc6
to
edb3630
Compare
SeroSun
changed the title
SeroSun
force-pushed
the
yosun/loadtest_xfstests
branch
from
edb3630
to
67022bc
Compare
SeroSun
changed the title
|
I could still see some get_var in lib code. I will modify them too. |
SeroSun
force-pushed
the
yosun/loadtest_xfstests
branch
2 times, most recently
from
a9178a1
to
c9d6a9e
Compare
SeroSun
changed the title
SeroSun
force-pushed
the
yosun/loadtest_xfstests
branch
from
c9d6a9e
to
903d008
Compare
SeroSun
changed the title
- Move function to a xfstests_util.pm file - Adjust function parameter passing part - Remove all get_var and check_var in lib function - Correct some comments
SeroSun
force-pushed
the
yosun/loadtest_xfstests
branch
from
903d008
to
bb444bd
Compare
SeroSun
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to do following this ticket https://progress.opensuse.org/issues/162884. To move current functions into lib:
The next step will create functions in lib to load sub-tests and rewrite the log analyst part.