Check SMELT to decide when SLES+HA tests can be skipped on QAM #19968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
alvarocarvajald
added
Verification-Runs-needed
qe-sap-ha
and removed
Verification-Runs-needed
labels
a-kpappas
reviewed
Aug 15, 2024
alvarocarvajald
force-pushed
the
check_qam_pkgs
branch
from
87d8398
to
bc60946
Compare
a-kpappas
approved these changes
Aug 15, 2024
The `lib/hacluster::is_not_maintenance` function was originally created to skip resource-expensive test modules when the package under test in Maintenance is not related to these tests (for example, `samba` or `ctdb` for `ha/ctdb` and `ha/filesystem`, `haproxy` for `ha/haproxy` or `drbd` for `ha/drbd_passive` and `ha/filesystem`). The function would decide this only based on the *BUILD* setting, which was supposed to contain the package under test, but in reality a Maintenance Update can include multiple packages and the one which is used in the *BUILD* setting is actually only the first package from the MU when ordered alphabetically. This of course causes some tests to be skipped even when it is necessary that they run. This commit modifies the `lib/hacluster::is_not_maintenance` function to also query SMELT for the list of packages associated to the Maintenance Incident, and then check against that list too after having checked against the value of the *BUILD* setting. This way, the function is more exhaustive in its checks, and should not skip necessary tests based on incomplete information. It also adds a check for `kernel`, as kernel maintenances should not skip any tests.
alvarocarvajald
force-pushed
the
check_qam_pkgs
branch
from
38f327d
to
de24f37
Compare
so it doesn't clash with the one in `ha/ctdb` when both test modules are scheduled in the same test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lib/hacluster::is_not_maintenancefunction was originally created to skip resource-expensive test modules when the package under test in Maintenance is not related to these tests (for example,sambaorctdbforha/ctdbandha/filesystem,haproxyforha/haproxyordrbdforha/drbd_passiveandha/filesystem). The function would decide this only based on the BUILD setting, which was supposed to contain the package under test, but in reality a Maintenance Update can include multiple packages and the one which is used in the BUILD setting is actually only the first package from the MU when ordered alphabetically. This of course causes some tests to be skipped even when it is necessary that they run.This commit modifies the
lib/hacluster::is_not_maintenancefunction to also query SMELT for the list of packages associated to the Maintenance Incident, and then check against that list too after having checked against the value of the BUILD setting. This way, the function is more exhaustive in its checks, and should not skip necessary tests based on incomplete information. It also adds a check forkernel, as kernel maintenances should not skip any tests.Verification runs
ha/ctdbtest should run fully): node 1, node 2, client 🟢ha/ctdbtest should run fully): node 1, node 2, client 🟢ha/ctdb,ha/drbd_passiveandha/haproxyshould run fully): node 1, node 2, client 🟢ha/ctdb,ha/drbd_passiveandha/haproxytests should be skipped): node 1, node 2, client 🟢