LTP: Adapt record_info() output to Micro #19983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
|
This error is not caused by changes I did: |
pevik
force-pushed
the
fix/add_custom_grub_entries
branch
from
28c5729
to
9021f8e
Compare
|
It could use |
|
But that would require to have |
Yes. |
pevik
force-pushed
the
fix/add_custom_grub_entries
branch
3 times, most recently
from
db5e21a
to
c14f2b4
Compare
mdoucha
reviewed
Aug 21, 2024
mdoucha
requested changes
Aug 21, 2024
pevik
force-pushed
the
fix/add_custom_grub_entries
branch
4 times, most recently
from
0dff7fa
to
404a9f8
Compare
mdoucha
approved these changes
Aug 22, 2024
Missing purge-kernels can be misleading (it's not e.g. on Micro). Let's check again for the binary before running it (as it was before 7af63e2). Signed-off-by: Petr Vorel <[email protected]>
By using enter_trup_shell and exit_trup_shell. Signed-off-by: Petr Vorel <[email protected]>
pevik
force-pushed
the
fix/add_custom_grub_entries
branch
from
404a9f8
to
80bee23
Compare
|
Restarted jobs, some of them already passed. |
pevik
added a commit
to pevik/os-autoinst-distri-opensuse
that referenced
this pull request
Aug 23, 2024
rpm -qi /tmp/kernel-pkg.txt 2>&1 needs to be in trup_shell for valid rpm packages, but also cannot be in trup shell, because then file is created somewhere else. Therefore instead using trup shell use 'transactional-update -c run' (as was in the original proposal os-autoinst#19983). This fixes error in boot_ltp cat: /tmp/ver_linux_before.txt: Fixes: 80bee23 ("LTP: Adapt record_info() output to Micro") Fixes: https://progress.opensuse.org/issues/165731 Reported-by: Petr Cervinka <[email protected]> Signed-off-by: Petr Vorel <[email protected]>
pevik
added a commit
to pevik/os-autoinst-distri-opensuse
that referenced
this pull request
Aug 23, 2024
rpm -qi /tmp/kernel-pkg.txt 2>&1 needs to be in trup_shell for valid rpm packages, but also cannot be in trup shell, because then file is created somewhere else. Therefore instead using trup shell use 'transactional-update -c run' (as was in the original proposal os-autoinst#19983). This fixes error in boot_ltp cat: /tmp/ver_linux_before.txt: Also run ver_linux via 'transactional-update -c run' to get updated packages version. Fixes: 80bee23 ("LTP: Adapt record_info() output to Micro") Fixes: https://progress.opensuse.org/issues/165731 Reported-by: Petr Cervinka <[email protected]> Signed-off-by: Petr Vorel <[email protected]>
pevik
added a commit
to pevik/os-autoinst-distri-opensuse
that referenced
this pull request
Aug 23, 2024
First, trup shell should be called after the system rebooted into the
latest snapshot, it will print wrong versions.
Also using 'rpm -qi /tmp/kernel-pkg.txt 2>&1' inside trup shell did
failed (on Micro):
This fixes error in boot_ltp
cat: /tmp/ver_linux_before.txt:
Therefore instead using trup shell use 'transactional-update -c run' (as
was in the original proposal os-autoinst#19983).
Also run ver_linux via 'transactional-update -c run' to get updated
packages version.
Fixes: 80bee23 ("LTP: Adapt record_info() output to Micro")
Fixes: https://progress.opensuse.org/issues/165731
Reported-by: Petr Cervinka <[email protected]>
Signed-off-by: Petr Vorel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification run:
kernel-rtwas visible: