-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout for script_run "test -e $inventory" #20004
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM, but I do have a suggestion regarding the changes below, and also, while checking the failure reported in the ticket, I believe a 90s timeout could be enough in some times and not enough in another, as root cause seems to be that the shell session is still busy with the previous command.
e4f489f
to
90c771a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
22084d9
to
781ec3c
Compare
What is previous command running that needs CTRL+C? Is it safe to terminate it like this? Generic approach of this particular qesap method is to be as less impacting as possible: get and upload as many logs as possible without perturbing test execution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A ssh command to connect to a VM in the cloud that has not timed out in the shell session, but that has timed out in It would be prudent to search every possible place this function is called on and what are the possible previous commands that are run in the shell session. In general a CTRL-C would not do anything if the shell is running and no command is blocking it, but if we want this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Avoid sles4sap_publiccloud_basetest post_fail_hook to fail in case of timeout at script_run("test -e $inventory")