LTP: Add 'Call Trace:' as failure in dmesg #20012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
pevik
force-pushed
the
ltp/dmesg-add-Call-Trace
branch
from
36f7dd2
to
65d70e8
Compare
pevik
force-pushed
the
ltp/dmesg-add-Call-Trace
branch
from
65d70e8
to
b725121
Compare
|
@mdoucha kindly did a verification for re-enabled serial for micro and it failed horribly, thus I removed that commit. Although the original test |
pevik
force-pushed
the
ltp/dmesg-add-Call-Trace
branch
2 times, most recently
from
241c019
to
012f25d
Compare
|
@mdoucha rebased |
pevik
force-pushed
the
ltp/dmesg-add-Call-Trace
branch
from
012f25d
to
dd1c1ca
Compare
mdoucha
reviewed
Aug 22, 2024
lib/known_bugs.pm
Outdated
| @@ -65,6 +65,7 @@ sub create_list_of_serial_failures { | |||
| push @$serial_failures, {type => $type, message => 'Kernel stack is corrupted', pattern => quotemeta 'stack-protector: Kernel stack is corrupted'}; | |||
| push @$serial_failures, {type => $type, message => 'Kernel BUG found', pattern => quotemeta 'BUG: failure at'}; | |||
| push @$serial_failures, {type => $type, message => 'Kernel Ooops found', pattern => quotemeta '-[ cut here ]-'}; | |||
| push @$serial_failures, {type => $type, message => 'Kernel Call Trace found', pattern => quotemeta 'Call Trace:'}; | |||
There was a problem hiding this comment.
I've just notice that every test which intentionally triggers OOM killer will produce a call trace in dmesg log. That'll also trigger this check. We should either set type => 'soft' here or drop the PR entirely.
There was a problem hiding this comment.
OK, I need to add type => 'soft'
There was a problem hiding this comment.
@mdoucha FYI updated to soft.
|
This PR would allow detecting the printk issue. VR on SLEM: https://openqa.suse.de/tests/15245908#step/boot_ltp/174 |
At least syslog11 on unfixed SLERT-15SP6 produced this output in dmesg. Link: https://bugzilla.suse.com/show_bug.cgi?id=1229025#c1 Signed-off-by: Petr Vorel <[email protected]>
pevik
force-pushed
the
ltp/dmesg-add-Call-Trace
branch
from
dd1c1ca
to
a56e954
Compare
mloviska
approved these changes
Aug 22, 2024
This is a result of the same function being defined in lib/main_common.pm and lib/main_security.pm. Worth to note, both are implemented differently. |
There were a lot more redefined function warnings but I've fixed them in #20026. We should leave this one to whoever actually uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least syslog11 on unfixed SLERT-15SP6 produced this output in dmesg.
Verification run: https://openqa.suse.de/tests/15246031#step/boot_ltp/174
(I was not able to find a test which would fail like this any more - although I cloned https://openqa.suse.de/tests/15153541, which has failing 6.4.0-150600.10.3-rt, test run with 6.4.0-150600.10.5-rt, which is already fixed).