Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce yaml files for minimal+base_yast #20157

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

okynos
Copy link
Contributor

@okynos okynos commented Sep 10, 2024

Copy link
Contributor

@rakoenig rakoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lemon-suse
Copy link
Contributor

PR LGTM, we need check the related MR then merge.

@jknphy
Copy link
Contributor

jknphy commented Oct 4, 2024

Please add the link to the MR (tip: open always both at the same time with WIP and then is easier not to forget).

@jknphy
Copy link
Contributor

jknphy commented Oct 4, 2024

Verification are not present anymore (true 3 weeks it is a lot of time to no have merged this but that is another topic). Could you please provide them?

@okynos
Copy link
Contributor Author

okynos commented Oct 7, 2024

@jknphy
Copy link
Contributor

jknphy commented Oct 7, 2024

Verification run:

all the runs show that the patterns to select are visible at first glance, so select_only_visible_patterns_from_top should be able to work in all of them, take into account the execution time of 51 seconds where select_patterns takes 5-6 minutes to 11 even, plus how it could unreliable could be iterate with that legacy module. That is the reason for that module to exists, the unification should try to use it if possible.

@jknphy
Copy link
Contributor

jknphy commented Oct 17, 2024

Please test this module for all verification if it really works or not, then we can consider what to do.

@okynos
Copy link
Contributor Author

okynos commented Oct 17, 2024

Yeah there is in the queue. Thanks for the reminder.

@okynos
Copy link
Contributor Author

okynos commented Oct 17, 2024

@okynos okynos force-pushed the 163253-reduce-minimal-base-yast branch from 3f54132 to 0b36238 Compare October 17, 2024 11:21
@okynos
Copy link
Contributor Author

okynos commented Oct 18, 2024

Reduce yaml files for minimal+base_yast

Reduce yaml files for minimal+base_yast

Change select patterns to select patterns from top

Added new key in default scehdules

Same fix for s390x-zVM
@okynos okynos force-pushed the 163253-reduce-minimal-base-yast branch from 567b827 to 08a727a Compare October 18, 2024 13:44
@jknphy jknphy merged commit 67bae93 into os-autoinst:master Oct 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants