Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kernel-default-devel for sle-micro #20436

Closed

Conversation

coolgw
Copy link
Contributor

@coolgw coolgw commented Oct 21, 2024

Add kernel-default-devel for sle-micro

NOTE:RT sle-micro not support currently.
sle-micro RT store source code into /usr/src/linux-rt(readonly filesystem), but LTP configuration set default path is /usr/src/linux

@coolgw coolgw requested a review from mdoucha October 21, 2024 02:29
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@coolgw coolgw requested review from czerw and pevik October 21, 2024 07:27
}
else {
return zypper_call('-t in ' . join(' ', map { $_->{name} } @$result));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you aware about install_package from package utils?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea when i create PR, but now i got it, thanks :)

zypper_install_available("kernel-rt-devel");
}
else {
zypper_install_available("kernel-default-devel");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devel package should be installed by default as dependency, so not need to install it in this way for normal kernel-default and kernel-rt has some other poo to fix ltp build for rt flavor. i think we dont need this PR at all

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For kernel-default-devel:
Currently kernel-default-devel can not be installed by default dependency, so we have poo#162827.
Base https://gitlab.suse.de/kernel-qa/ltp-pkg/-/merge_requests/40#note_667811 i thought should add above code.
So where /how to let kernel-default-devel package installed automaticlly by dependency for sle-micro?

For kernel-rt:
Which progress ticket will tracking this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not specifically about kernel-rt but about adding multibuild support to ltp package in ibs/obs to have specific ltp version build against particular kernel. Test should work fine on kernel-default and just skip it on rt flavor for now.

@coolgw coolgw closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants