Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report fallback CA #20440

Closed
wants to merge 1 commit into from
Closed

Report fallback CA #20440

wants to merge 1 commit into from

Conversation

grisu48
Copy link
Contributor

@grisu48 grisu48 commented Oct 21, 2024

In case the distribution for the SUSE CA is not yet published and we fallback to SLE-Factory, report it explicitly with record_info.

In case the distribution for the SUSE CA is not yet published and we
fallback to SLE-Factory, report it explicitly with record_info.
@grisu48 grisu48 requested a review from m-dati October 21, 2024 07:15
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@grisu48 grisu48 marked this pull request as ready for review October 21, 2024 07:47
@mloviska
Copy link
Contributor

mloviska commented Oct 21, 2024

I lack to see the value of making this information verbose. At the end all the certificates are the same, just the link differs, and it doesn't matter for the test whether they come from repo for SP6 or a generic one.

@grisu48
Copy link
Contributor Author

grisu48 commented Oct 21, 2024

I lack to see the value of making this information verbose. At the end all the certificates are the same, just the link differs, and it doesn't matter for the test whether they come from repo for SP6 or a generic one.

Especially for newer version we often need to poke some people so that they enable it in this repository. Making it visible that the build is missing helps us to poke the right people to make it happen on time.

@m-dati
Copy link
Contributor

m-dati commented Oct 21, 2024

Only to mention: I opened a discussion on certificates in this channel, where distri-differences were considered not much relevant, but a clear report of it may be useful.

@mloviska
Copy link
Contributor

Only to mention: I opened a discussion on certificates in this channel, where distri-differences were considered not much relevant, but a clear report of it may be useful.

I would stick to what was Marcus said, the CA is the same for the whole product series. In this particular setup, it will be a red herring outside SLE-15-SPx and one does need to know certain background information in order to handle this informative record_info.

Also, it will be simply another green info box that won't make reviewers without additional information to take any actions.

@grisu48
Copy link
Contributor Author

grisu48 commented Oct 21, 2024

Agreed, probably not worth it. Closing now.

@grisu48 grisu48 closed this Oct 21, 2024
@grisu48 grisu48 deleted the diag_no_more branch October 21, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants