microos/image_checks: Expect unpartitioned 2048 sectors at disk start #20454
Conversation
rbmarliere
requested review from
mloviska and
ricardobranco777
as code owners
tests/microos/image_checks.pm
Outdated
| @@ -42,6 +42,9 @@ sub run { | |||
| $left_sectors = 1792; | |||
| record_soft_failure "bsc#1220722: no unpartitioned space left on aarch64"; | |||
| } | |||
| if (is_leap_micro("5.4+") && is_aarch64) { | |||
There was a problem hiding this comment.
I believe this is the same as L#36.
Anyway, this whole left sectors logic should be refactored. Because it has become a mess. If you wish to, it would be nice to make it an if-elsif-else block.
There was a problem hiding this comment.
Sorry L#35. Also it makes product wise sense considering that sle-leap gap has been addressed in the past and the products have become closer in later releases
There was a problem hiding this comment.
L#36 checks with is_sle_micro, whereas I used is_leap_micro. I'll try improving readability.
There was a problem hiding this comment.
As I have mentioned, the gap between sle and leap family has been addressed and should have the same properties as much as possible. In this particular case, if sle-micro('x') has left over sectors y, the same should be expected in leap-micro('x').
There was a problem hiding this comment.
Fixed in f677e5e
For Leap Micro 5.4+ aarch64 builds, there is an 1M unpartitioned space that needs to be accounted for. Signed-off-by: Ricardo B. Marliere <[email protected]>
For Leap Micro 5.4+ aarch64 builds, there is an 1M unpartitioned space that needs to be accounted for.