Include GPU check validation #20840
Open
Include GPU check validation #20840
+43
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarunachalam
requested review from
pdostal,
grisu48,
asmorodskyi,
ricardobranco777,
m-dati and
rbmarliere
as code owners
yarunachalam
force-pushed
the
gpucheck
branch
from
3202a12 to
99aee72
Compare
m-dati
reviewed
Dec 19, 2024
m-dati
reviewed
Dec 19, 2024
m-dati
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Please also consider an update as by suggestions in the previous PR #20723 (comment), related to Lines here starting from L261 up to L278
yarunachalam
force-pushed
the
gpucheck
branch
from
99aee72 to
90db577
Compare
yarunachalam
force-pushed
the
gpucheck
branch
4 times, most recently
from
4551661 to
227d35c
Compare
m-dati
reviewed
Jan 8, 2025
Comment on lines
269
to
275
| assert_script_run("curl --output /dev/null --silent --head --write-out \"%{http_code}\n\" -k -L https://$host_name"); | ||
| my $curl_cmd = "curl --output /dev/null --silent --head --write-out \"%{http_code}\n\" -k -L https://$host_name"; | ||
| my $curl_result = script_output($curl_cmd); | ||
| record_info("http code: $curl_result \n"); | ||
| if ($curl_result == 200) { | ||
| record_info("Successfully connected to the open-webui service at $curl_cmd \n"); | ||
| } else { | ||
| # connect open-webui service | ||
| assert_script_run("curl --output /dev/null --silent --head --write-out \"%{http_code}\n\" -k -L https://$host_name"); | ||
| my $curl_cmd = "curl --output /dev/null --silent --head --write-out \"%{http_code}\n\" -k -L https://$host_name"; | ||
| my $curl_result = script_output($curl_cmd); | ||
| record_info("http code: $curl_result \n"); | ||
| if ($curl_result == 200) { | ||
| record_info("Successfully connected to the open-webui service at $curl_cmd \n"); | ||
| } else { | ||
| die "Received unexpected HTTP error code $curl_result for $curl_cmd\n"; | ||
| } | ||
| die "Received unexpected HTTP error code $curl_result for $curl_cmd\n"; |
There was a problem hiding this comment.
Still here you repeat twice the same curl commands in a long snippet, and even added a more unclear new else-block, that all could be simplified using the validate command, as also mentioned in note #20840 (review).
Please, re-check my suggestions in
#20723 (comment) and apply here those, replacing all lines here from L269 to L277, with the suggested changes, using validate... command in place of the full if, also here re-proposed:
Suggested change
| assert_script_run("curl --output /dev/null --silent --head --write-out \"%{http_code}\n\" -k -L https://$host_name"); | |
| my $curl_cmd = "curl --output /dev/null --silent --head --write-out \"%{http_code}\n\" -k -L https://$host_name"; | |
| my $curl_result = script_output($curl_cmd); | |
| record_info("http code: $curl_result \n"); | |
| if ($curl_result == 200) { | |
| record_info("Successfully connected to the open-webui service at $curl_cmd \n"); | |
| } else { | |
| # connect open-webui service | |
| assert_script_run("curl --output /dev/null --silent --head --write-out \"%{http_code}\n\" -k -L https://$host_name"); | |
| my $curl_cmd = "curl --output /dev/null --silent --head --write-out \"%{http_code}\n\" -k -L https://$host_name"; | |
| my $curl_result = script_output($curl_cmd); | |
| record_info("http code: $curl_result \n"); | |
| if ($curl_result == 200) { | |
| record_info("Successfully connected to the open-webui service at $curl_cmd \n"); | |
| } else { | |
| die "Received unexpected HTTP error code $curl_result for $curl_cmd\n"; | |
| } | |
| die "Received unexpected HTTP error code $curl_result for $curl_cmd\n"; | |
| record_info("http check”, $host_name); | |
| my $curl_cmd = "curl --output /dev/null --silent --head --write-out '%{http_code}\n' -k -L https://$host_name"; | |
| validate_script_output("$curl_cmd", qr/200/, fail_message => "Received unexpected HTTP error code from $host_name"); |
Moreover, consider that in curl you will no more need double-quotes and escaping slash \"...\" if you use single quotes '...'; try it on your console, with some test url.
|
After a new git-branch is pushed and updated in PR, please also post a new VR test run link in PR (possibly at every relevant update), to see the new code correctly working. |
yarunachalam
commented
Jan 8, 2025
yarunachalam
force-pushed
the
gpucheck
branch
10 times, most recently
from
d924fcf to
bc54dc2
Compare
yarunachalam
force-pushed
the
gpucheck
branch
2 times, most recently
from
3e5c8c8 to
5d42e59
Compare
Do not exist for log issues only pod failure.
yarunachalam
force-pushed
the
gpucheck
branch
from
5d42e59 to
8219f33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include GPU check validation for NVIDIA test flavor