Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os-autoinst-obs-auto-submit: Mark expected failure explicitly #368

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

okurz
Copy link
Member

@okurz okurz commented Jan 30, 2025

This is a follow-up to 6fd3443 keeping the pipefail flag intact but
explicitly discarding the exit code of the "diff" call which should not
impact the further evaluation. I tested this manually with two differing
fails and checking the exit code like this:

set -o pipefail
diff file1 file2 | grep $content
(diff file1 file2 ||:) | grep $content

Related progress issue: https://progress.opensuse.org/issues/176316

Related to

os-autoinst-obs-auto-submit Outdated Show resolved Hide resolved
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you only need to fix the style check.

This is a follow-up to 6fd3443 keeping the pipefail flag intact but
explicitly discarding the exit code of the "diff" call which should not
impact the further evaluation. I tested this manually with two differing
fails and checking the exit code like this:

```
set -o pipefail
diff file1 file2 | grep $content
{ diff file1 file2 ||:; } | grep $content
```

Related progress issue: https://progress.opensuse.org/issues/176316
@mergify mergify bot merged commit ca25be5 into os-autoinst:master Jan 30, 2025
4 checks passed
@okurz okurz deleted the feature/pipefail branch January 30, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants