Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait until all packages in the snapshot are actually published #369

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

baierjan
Copy link
Member

@baierjan baierjan commented Jan 30, 2025

First we ensure all wanted packages inside devel:openQA are published properly, after that we "release" them via osc release. As this is not an atomic operation and OBS still needs some time to properly publish the copied packages, we can use osc prjresult -w to wait until that happens. That will ensure that the staging project (i.e. devel:openQA:testing) does contain some binaries packages to test.

Reference: https://progress.opensuse.org/issues/174451

Comment on lines +83 to +84
echo "Wait until all packages are published under $staging_project"
$osc prjresults --watch --xml -r openSUSE_Tumbleweed -a x86_64 "$staging_project"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the packages in the staging project are created via osc release I'm not sure whether waiting will help here. At least my theory was that when invoking osc release not all packages were published so the packages released into the staging project were stuck with no package being published. If waiting the releasing would help then the retry within the test code should already be sufficient (but it is not as far as I remember; otherwise we would not have this issue in the first place, right?).

Copy link
Member Author

@baierjan baierjan Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the linked ticket and slack conversation there; in our case osc release will "release" the package just fine. It is just not published right away, but the job takes a while to complete (hence we can monitor the state with the osc results / osc prjresults). This change should make sure, all packages which were copied over by the osc release are published and we don't end up with starting the test with an empty repository like we currently do in https://openqa.opensuse.org/tests/4819550.

If waiting the releasing would help then the retry within the test code should already be sufficient.

Yes, unless OBS is stuck with the build process (like it is apparently now) and the release process takes longer. On the other hand, you can end up testing Factory instead of devel:openQA:testing like exactly now, because there is nothing preventing you from installing openQA from Factory if devel:openQA:testing is empty.

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this isn't entirely obvious please put more details into the git commit message. Rest is fine

First we ensure all wanted packages inside devel:openQA are published
properly, after that we "release" them via `osc release`. As this is not
an atomic operation and OBS still needs some time to properly publish
the copied packages, we can use `osc prjresult -w` to wait until that
happens. That will ensure that the staging project (i.e.
devel:openQA:testing) does contain some binaries packages to test.

Reference: https://progress.opensuse.org/issues/174451
@baierjan baierjan force-pushed the consistent-snapshots branch from ae80cee to fed9746 Compare January 30, 2025 14:51
@baierjan
Copy link
Member Author

As this isn't entirely obvious please put more details into the git commit message. Rest is fine

I tried to formulate the "story" into the commit.

@mergify mergify bot merged commit d606604 into master Jan 30, 2025
6 checks passed
@mergify mergify bot deleted the consistent-snapshots branch January 30, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants