Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: alert message bug #23

Merged
merged 2 commits into from
Jan 25, 2024
Merged

fix: alert message bug #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb96cd0
fix: alert message bug
maryam4s26 Jan 23, 2024
54f7c28
fix: alert message bug
maryam4s26 Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/dialogs/alert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
* @param {Function} callback The callback function
*/
constructor(core, args, callback) {
args = Object.assign({}, {

Check warning on line 52 in src/dialogs/alert.js

View workflow job for this annotation

GitHub Actions / Lint tests (node latest) 

Use an object spread instead of `Object.assign` eg: `{ ...foo }`
title: 'Alert',
type: 'info',
message: ''
Expand Down Expand Up @@ -84,9 +84,7 @@

if (this.args.type === 'error') {
const {error} = this.args;
const msg = error instanceof Error
? (error.stack ? error.stack : error)
: String(error);
const msg = error instanceof Error ? `${error.message}\n\n${error.stack || 'No stack'}` : error;

children.push(h(TextareaField, {value: msg, readonly: true, placeholder: this.args.message}));
}
Expand Down
Loading